On Thu, Jun 29, 2017 at 04:22:58PM +0800, zhongbaisong wrote:
> This commit add the support to set mtu with ovs-vsctl command like:
> ovs-vsctl set interface port mtu=2000
>
> Signed-off-by: zhongbaisong <[email protected]>
Thanks for contributing to Open vSwitch!
"checkpatch" says:
ERROR: Inappropriate bracing around statement
#36 FILE: vswitchd/bridge.c:4456:
if (iface->change_seq != netdev_get_change_seq(iface->netdev))
ERROR: Inappropriate bracing around statement
#40 FILE: vswitchd/bridge.c:4460:
if (n_mtu == 0)
But to me this patch does not make conceptual sense. The mtu column
reports an interface's MTU, it does not set it, and there is already a
column to set MTU. Please read the documentation:
MTU:
The MTU (maximum transmission unit) is the largest amount of data that
can fit into a single Ethernet frame. The standard Ethernet MTU is 1500
bytes. Some physical media and many kinds of virtual interfaces can be
configured with higher MTUs.
A client may change an interface MTU by filling in mtu_request. Open
vSwitch then reports in mtu the currently configured value.
mtu: optional integer
The currently configured MTU for the interface.
This column will be empty for an interface that does not have an
MTU as, for example, some kinds of tunnels do not.
Open vSwitch sets this column’s value, so other clients should
treat it as read-only.
mtu_request: optional integer, at least 1
Requested MTU (Maximum Transmission Unit) for the interface. A
client can fill this column to change the MTU of an interface.
RFC 791 requires every internet module to be able to forward a
datagram of 68 octets without further fragmentation. The maximum
size of an IP packet is 65535 bytes.
If this is not set and if the interface has internal type, Open
vSwitch will change the MTU to match the minimum of th
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
