Hi Ales Thanks for the review. Some comments below.
Thanks Xavier On Thu, Apr 2, 2026 at 3:20 PM Ales Musil <[email protected]> wrote: > > > On Thu, Apr 2, 2026 at 3:14 PM Xavier Simonart via dev < > [email protected]> wrote: > >> From: Dumitru Ceara <[email protected]> >> >> The test was still testing upgrades from 22.03 to HEAD, which jumps over >> the latest LTS, 24.03. That's an unsupported upgrade path. Change the >> test to check that upgrading from 24.03 to HEAD works. >> >> Signed-off-by: Dumitru Ceara <[email protected]> >> Acked-by: Ales Musil <[email protected]> >> (cherry picked from commit 4f3952a6e0d4d656aae2dcb0dc0897549db91519) >> --- >> > > Hi Xavier, > > just one thought that we have discussed with Dumitru > offline. Maybe we should remove the upgrade portion > and keep it only on LTS (26.03) and main. Those tests > do not run regularly anyway and for testing of backport > it's enough to have only the "main" part. WDYT? > As discussed offline, this is probably one of the last backports reaching 24.03. So we should probably keep the upgrade patch for versions 25.03 and 24.09, but remove it for 24.03. > > .github/workflows/ovn-fake-multinode-tests.yml | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/.github/workflows/ovn-fake-multinode-tests.yml >> b/.github/workflows/ovn-fake-multinode-tests.yml >> index 39ada1a08..11fd7dc08 100644 >> --- a/.github/workflows/ovn-fake-multinode-tests.yml >> +++ b/.github/workflows/ovn-fake-multinode-tests.yml >> @@ -19,7 +19,7 @@ jobs: >> matrix: >> cfg: >> - { repo: "${{ github.repository }}", branch: "${{ >> github.ref_name }}" } >> - - { repo: ovn-org/ovn, branch: "branch-22.03" } >> + - { repo: ovn-org/ovn, branch: "branch-24.03" } >> env: >> RUNC_CMD: podman >> OS_IMAGE: "fedora:42" >> @@ -91,7 +91,7 @@ jobs: >> matrix: >> cfg: >> - { branch: "${{ github.ref_name }}", testsuiteflags: ""} >> - - { branch: "branch-22.03", testsuiteflags: "-k 'basic test'" } >> + - { branch: "branch-24.03", testsuiteflags: "-k 'basic test'" } >> name: multinode tests ${{ join(matrix.cfg.*, ' ') }} >> env: >> RUNC_CMD: podman >> @@ -142,12 +142,12 @@ jobs: >> >> - uses: actions/download-artifact@v8 >> with: >> - name: test-branch-22.03-image >> + name: test-branch-24.03-image >> >> - name: Load podman image >> run: | >> sudo podman load --input ovn_${{ github.ref_name }}_image.tar >> - sudo podman load --input ovn_branch-22.03_image.tar >> + sudo podman load --input ovn_branch-24.03_image.tar >> >> - name: Check out ovn-fake-multi-node >> uses: actions/checkout@v6 >> -- >> 2.47.1 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Thanks, > Ales > Thanks Xavier _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
