On 4/2/26 10:25 AM, Ales Musil wrote:
> The netlink notifiers used a lot of code that was more or less
> identical to each other. Extract the common code into separate module
> which allows the definition of listeners and their specific data.
> This should make it easier to add any new notifier, which will be the
> case in the future. It should also make it slightly easier to track
> individual updates and changes that could be processed incrementally
> instead of full recompute when there is any change.
> 
> Signed-off-by: Ales Musil <[email protected]>
> ---

Hi Ales,

> -dnl Should NOT notify if an entry is added to a bridge that's not monitored 
> by
> +dnl Should notify if an entry is removed from a bridge that's monitored by
>  dnl OVN.
> -check ovstest test-ovn-netlink neighbor-table-notify br-test $br_if_index \
> +AT_CHECK_UNQUOTED([ovstest test-ovn-netlink neighbor-table-notify \
> +    'ip neigh del 10.10.10.10 lladdr 00:00:00:00:10:00 \
> +        dev br-test' | sort], [0], [dnl
> +Add neighbor ifindex=$br_if_index vlan=0 eth=00:00:00:00:00:00 
> dst=10.10.10.10 port=0
> +Delete neighbor ifindex=$br_if_index vlan=0 eth=00:00:00:00:00:00 
> dst=10.10.10.10 port=0
> +])
> +
> +dnl Should NOT notify if an noarp entry is added to a bridge port

Typo: a noarp

With that addressed:

Acked-by: Dumitru Ceara <[email protected]>

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to