On 7/13/17, 11:48 AM, "[email protected] on behalf of Ben Pfaff"
<[email protected] on behalf of [email protected]> wrote:
On Wed, Jul 05, 2017 at 09:32:21PM -0700, Darrell Ball wrote:
> Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.")
> Fixes: 286de2729955 ("dpdk: Userspace Datapath: Introduce NAT Support.")
> Signed-off-by: Darrell Ball <[email protected]>
Thanks for the patches. I applied patches 1, 2, and 3 to master. I'm
continuing to review the series.
On this patch, I'm not sure why some of the annotations are comments
rather than OVS_REQUIRES.
Some of the annotations are comments, because I did not want to add a dummy
parameter
for the lock, just so OVS_REQUIRES could reference it and I did not want to
pass the
whole ct context instead of the minimum set of contained fields, as I wanted to
keep
the function scope as narrow as possible.
_______________________________________________
dev mailing list
[email protected]
https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=oOHwmwpSeF3VyC1N0ufHTb8Nncq3SXci21ObHremhOA&s=Rpt7NNrFXzz-tAT-zdSOp2MA718sn2zz_RLFWUyBvrc&e=
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev