On 16 Apr 2026, at 14:29, Eli Britstein wrote:
> On 15/04/2026 14:42, Eelco Chaudron wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> This patch refactors the DPDK offload test infrastructure to simplify
>> the interface configuration. Instead of using OVS_DPDK_VF_PCI_ADDRS
>> with a space-separated list of PCI addresses and VF indices (e.g.,
>> "0000:17:00.0,0 0000:17:00.0,1"), the tests now use OVS_PF_PCI
>> with a single PF address (e.g., "0000:17:00.0") and derive VF
>> information from sysfs.
>>
>> Signed-off-by: Eelco Chaudron <[email protected]>
>> ---
>> Changes to v3:
>> - Fixed documentation.
>> - Changed test macro names from xxxx_netdev() to xxx_port().
>> - Use local variables in shell macros.
>> Changes to v2:
>> - Use PCI address rather than port name, so other blades might
>> be supported.
>> - Moved/renamed shell helpers.
>> - Updated documentation.
>> ---
>> Documentation/topics/testing.rst | 24 +++---
>> tests/system-common-macros.at | 90 ++++++++++++++++++++++
>> tests/system-dpdk-offloads-macros.at | 108 ++++-----------------------
>> 3 files changed, 120 insertions(+), 102 deletions(-)
>
> Hi Eelco,
>
> The macros still has some references to "netdev" instead of "port" (see
> below). Other than that LGTM.
>
> Those are only comments there, so I'm fine also with keeping it.
>
> If you prefer to keep:
>
> Acked-by: Eli Britstein <[email protected]>
I changed the API as we use ports in the test cases. For the description, I
kept netdev as these are what they are from a Linux perspective.
Once again thanks for your review, and I applied these changes to main!
//Eelco
[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
