Re: [ovs-dev] [PATCH ovn 3/5] northd: Split logical flow docs into ovn-logical-flows(7).

Tue, 28 Apr 2026 11:00:13 -0700 

Bleep bloop.  Greetings Mark Michelson, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#879 FILE: northd/ovn-logical-flows.7.xml:842:
        <code>reg1[16..23] = ct_proto(); reg1[0..15] = ct_tp_dst(); 
next;</code>.

WARNING: Line is 80 characters long (recommended limit is 79)
#975 FILE: northd/ovn-logical-flows.7.xml:938:
        ct_lb_mark(<var>args</var>)</code>, where <var>args</var> contains comma

WARNING: Line is 201 characters long (recommended limit is 79)
#1570 FILE: northd/ovn-logical-flows.7.xml:1533:
<code>inport == <var>P</var> &amp;&amp; &amp;&amp; ((arp.op == 1 &amp;&amp; 
arp.spa == <var>VIP</var> &amp;&amp; arp.tpa == <var>VIP</var>) || (arp.op == 2 
&amp;&amp; arp.spa == <var>VIP</var>))</code>

WARNING: Line is 214 characters long (recommended limit is 79)
#1571 FILE: northd/ovn-logical-flows.7.xml:1534:
<code>inport == <var>P</var> &amp;&amp; &amp;&amp; ((nd_ns &amp;&amp; ip6.dst 
== <var>{VIP, NS_MULTICAST_ADDR}</var> &amp;&amp; nd.target == <var>VIP</var>) 
|| (nd_na &amp;&amp; nd.target == <var>VIP</var>))</code>

WARNING: Line is 81 characters long (recommended limit is 79)
#1894 FILE: northd/ovn-logical-flows.7.xml:1857:
          with DHCPv4 options which matches IPv4 packets with <code>udp.src == 
68

WARNING: Line is 82 characters long (recommended limit is 79)
#1927 FILE: northd/ovn-logical-flows.7.xml:1890:
          with DHCPv6 options which matches IPv6 packets with <code>udp.src == 
546

WARNING: Line is 81 characters long (recommended limit is 79)
#2533 FILE: northd/ovn-logical-flows.7.xml:2496:
      reg8[22] = 1; reg0[22..29] = <var>id</var></code>. These registers are 
used

WARNING: Line is 81 characters long (recommended limit is 79)
#2557 FILE: northd/ovn-logical-flows.7.xml:2520:
        has DHCPv4 options defined to allow the DHCPv4 reply packet and which 
has

WARNING: Line is 80 characters long (recommended limit is 79)
#2668 FILE: northd/ovn-logical-flows.7.xml:2631:
        &amp;&amp; reg8[22] == 1 &amp;&amp; reg0[22..29] == <var>id</var></code>

WARNING: Line is 82 characters long (recommended limit is 79)
#4204 FILE: northd/ovn-logical-flows.7.xml:4167:
          <code>ct_lb_mark(<var>args</var>)</code>, where <var>args</var> 
contains

WARNING: Line is 82 characters long (recommended limit is 79)
#4231 FILE: northd/ovn-logical-flows.7.xml:4194:
          <code>ct_lb_mark(<var>args</var>)</code>, where <var>args</var> 
contains

WARNING: Line is 94 characters long (recommended limit is 79)
#4822 FILE: northd/ovn-logical-flows.7.xml:4785:
          <code>reg8[0..15] == <var>GID</var> &amp;&amp; reg8[16..31] == 
<var>MID</var></code>

WARNING: Line is 101 characters long (recommended limit is 79)
#5065 FILE: northd/ovn-logical-flows.7.xml:5028:
          <code>push(xxreg1); xxreg1 = ct_label; eth.dst = xxreg1[32..79]; 
pop(xxreg1); next;</code>.

Lines checked: 12199, Warnings: 13, Errors: 0


Please check this out.  If you feel there has been an error, please email 
[email protected]

Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to