Minxi Hou <[email protected]> writes: > Add VLAN TCI formatting and parsing support to ovs-dpctl.py: > > - Add _vlan_dpstr() to decompose TCI into vid/pcp/cfi fields, > with raw tci=0x%04x fallback when cfi=0 for round-trip safety. > - Add _parse_vlan_from_flowstr() boundary check for missing ')'. > - Add encap_ovskey subclass restricting nla_map to L2-L4 attributes > (slots 0-21) that appear inside 802.1Q ENCAP, with metadata > attributes set to "none". > - Check parse() return value for unrecognized trailing content. > - Support callable format functions in dpstr() output. > - Change OVS_KEY_ATTR_VLAN type from uint16 to be16 to match the > kernel __be16 wire format; uint16 decodes in host byte order, > which gives wrong values on little-endian architectures. > - Change OVS_KEY_ATTR_ENCAP type from none to encap_ovskey to > enable recursive parsing of 802.1Q encapsulated flow keys. > - Add push_vlan action class with fields matching kernel struct > ovs_action_push_vlan (vlan_tpid, vlan_tci as network-order u16). > - Add push_vlan dpstr format and parse with range validation > (vid 0-4095, pcp 0-7, tpid 0-0xFFFF) and CFI forced to 1. > - Remove MAX_ENCAP_DEPTH constant and depth tracking -- the > bracket-depth counter in the encap parser already handles > nesting; the global depth limit was unnecessary. > > Signed-off-by: Minxi Hou <[email protected]> > ---
There are probably some pylint flags in this patch, but as stated before it is okay because they are keeping the coding style in this file consistent. Reviewed-by: Aaron Conole <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
