Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 173 characters long (recommended limit is 79)
#70 FILE: utilities/ovn-nbctl.8.xml:639:
<dt>[<code>--fair</code>] [<code>--may-exist</code>]
<code>meter-add</code> <var>name</var> <var>action</var> <var>rate</var>
<var>unit</var> [<var>burst</var>]</dt>
WARNING: Line is 288 characters long (recommended limit is 79)
#248 FILE: utilities/ovn-nbctl.8.xml:1569:
<dt>[<code>--may-exist</code> | <code>--add-duplicate</code> |
<code>--reject</code> | <code>--event</code> | <code>--template</code> |
<code>--add-route</code>] <code>lb-add</code> <var>lb</var> <var>vip</var>
<var>ips</var> [<var>protocol</var>] [<var>address_family</var>]</dt>
WARNING: Line lacks whitespace around operator
#329 FILE: utilities/ovn-nbctl.c:292:
[--may-exist | --add-duplicate]\n\
WARNING: Line lacks whitespace around operator
#331 FILE: utilities/ovn-nbctl.c:294:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#338 FILE: utilities/ovn-nbctl.c:299:
[--type={switch | port-group}] [--log] [--severity=SEVERITY]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#339 FILE: utilities/ovn-nbctl.c:300:
[--name=NAME] [--meter=METER] [--label=LABEL] [--may-exist]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#340 FILE: utilities/ovn-nbctl.c:301:
[--apply-after-lb] [--tier=TIER]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#341 FILE: utilities/ovn-nbctl.c:302:
[--sample-new=COLLECTOR_SET_ID] [--sample-est=COLLECTOR_SET_ID]\n\
WARNING: Line lacks whitespace around operator
#342 FILE: utilities/ovn-nbctl.c:303:
acl-add {SWITCH | PORTGROUP} DIRECTION PRIORITY MATCH ACTION\n\
WARNING: Line lacks whitespace around operator
#343 FILE: utilities/ovn-nbctl.c:304:
[NETWORK-FUNCTION-GROUP]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#346 FILE: utilities/ovn-nbctl.c:306:
[--type={switch | port-group}] [--tier=TIER]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#350 FILE: utilities/ovn-nbctl.c:309:
[--type={switch | port-group}] [--all]\n\
WARNING: Line lacks whitespace around operator
#353 FILE: utilities/ovn-nbctl.c:311:
print ACLs for SWITCH/PORTGROUP\n\
WARNING: Line lacks whitespace around operator
#358 FILE: utilities/ovn-nbctl.c:314:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#359 FILE: utilities/ovn-nbctl.c:315:
qos-add SWITCH DIRECTION PRIORITY MATCH [rate=RATE [burst=BURST]]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#360 FILE: utilities/ovn-nbctl.c:316:
[dscp=DSCP] [mark=MARK]\n\
WARNING: Line lacks whitespace around operator
#368 FILE: utilities/ovn-nbctl.c:323:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#369 FILE: utilities/ovn-nbctl.c:324:
mirror-add NAME TYPE [INDEX] FILTER DEST\n\
WARNING: Line lacks whitespace around operator
#391 FILE: utilities/ovn-nbctl.c:328:
mirror-rule-add MIRROR-NAME PRIORITY MATCH ACTION\n\
WARNING: Line lacks whitespace around operator
#394 FILE: utilities/ovn-nbctl.c:331:
mirror-rule-del MIRROR-NAME [PRIORITY MATCH]\n\
WARNING: Line lacks whitespace around operator
#399 FILE: utilities/ovn-nbctl.c:335:
[--fair] [--may-exist]\n\
WARNING: Line lacks whitespace around operator
#406 FILE: utilities/ovn-nbctl.c:342:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#411 FILE: utilities/ovn-nbctl.c:347:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#420 FILE: utilities/ovn-nbctl.c:364:
lsp-set-type PORT TYPE [peer=PEER]\n\
WARNING: Line lacks whitespace around operator
#429 FILE: utilities/ovn-nbctl.c:377:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#438 FILE: utilities/ovn-nbctl.c:380:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#439 FILE: utilities/ovn-nbctl.c:381:
lsp-add-router-port SWITCH PORT LRP_PEER\n\
WARNING: Line lacks whitespace around operator
#441 FILE: utilities/ovn-nbctl.c:383:
router-port set to LRP_PEER\n\
WARNING: Line lacks whitespace around operator
#442 FILE: utilities/ovn-nbctl.c:384:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#443 FILE: utilities/ovn-nbctl.c:385:
lsp-add-localnet-port SWITCH PORT NETWORK\n\
WARNING: Line lacks whitespace around operator
#451 FILE: utilities/ovn-nbctl.c:393:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#454 FILE: utilities/ovn-nbctl.c:395:
fwd-group-list [GROUP] print forwarding groups\n\
WARNING: Line lacks whitespace around operator
#457 FILE: utilities/ovn-nbctl.c:398:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#460 FILE: utilities/ovn-nbctl.c:401:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#464 FILE: utilities/ovn-nbctl.c:404:
nfg-list [NETWORK-FUNCTION-GROUP]\n\
WARNING: Line lacks whitespace around operator
#465 FILE: utilities/ovn-nbctl.c:405:
print network-function-groups\n\
WARNING: Line lacks whitespace around operator
#466 FILE: utilities/ovn-nbctl.c:406:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#470 FILE: utilities/ovn-nbctl.c:410:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#476 FILE: utilities/ovn-nbctl.c:416:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#479 FILE: utilities/ovn-nbctl.c:419:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#485 FILE: utilities/ovn-nbctl.c:425:
[--may-exist | --add-duplicate]\n\
WARNING: Line lacks whitespace around operator
#487 FILE: utilities/ovn-nbctl.c:427:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#493 FILE: utilities/ovn-nbctl.c:432:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#494 FILE: utilities/ovn-nbctl.c:433:
lrp-add ROUTER PORT MAC [NETWORK]... [COLUMN[:KEY]=VALUE]...\n\
WARNING: Line lacks whitespace around operator
#496 FILE: utilities/ovn-nbctl.c:435:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#504 FILE: utilities/ovn-nbctl.c:445:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#517 FILE: utilities/ovn-nbctl.c:463:
[--may-exist] [--policy=POLICY] [--ecmp] [--ecmp-symmetric-reply]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#518 FILE: utilities/ovn-nbctl.c:464:
[--route-table=ROUTE_TABLE] [--bfd]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#523 FILE: utilities/ovn-nbctl.c:467:
[--if-exists] [--policy=POLICY] [--route-table=ROUTE_TABLE]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#534 FILE: utilities/ovn-nbctl.c:474:
[--may-exist] [--bfd] [--chain=CHAIN] [--output-port=OUTPUT_PORT]\n\
WARNING: Line lacks whitespace around operator
#535 FILE: utilities/ovn-nbctl.c:475:
lr-policy-add ROUTER PRIORITY MATCH ACTION [NEXTHOP,[NEXTHOP,...]]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#536 FILE: utilities/ovn-nbctl.c:476:
[OPTIONS KEY=VALUE ...]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#538 FILE: utilities/ovn-nbctl.c:478:
[--if-exists] [--chain=CHAIN]\n\
WARNING: Line lacks whitespace around operator
#551 FILE: utilities/ovn-nbctl.c:485:
[--may-exist] [--stateless] [--portrange] [--add-route]\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#552 FILE: utilities/ovn-nbctl.c:486:
[--gateway-port=GATEWAY_PORT] [--priority=PRIORITY] [--match=MATCH]\n\
WARNING: Line lacks whitespace around operator
#553 FILE: utilities/ovn-nbctl.c:487:
lr-nat-add ROUTER TYPE EXTERNAL_IP LOGICAL_IP\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#556 FILE: utilities/ovn-nbctl.c:490:
[--if-exists] [--match=MATCH]\n\
WARNING: Line lacks whitespace around operator
#560 FILE: utilities/ovn-nbctl.c:494:
[--is-exempted]\n\
WARNING: Line lacks whitespace around operator
#561 FILE: utilities/ovn-nbctl.c:495:
lr-nat-update-ext-ip ROUTER TYPE IP ADDRESS_SET\n\
WARNING: Line lacks whitespace around operator
#566 FILE: utilities/ovn-nbctl.c:499:
[--may-exist | --add-duplicate] [--reject] [--event] [--template]\n\
WARNING: Line lacks whitespace around operator
#567 FILE: utilities/ovn-nbctl.c:500:
[--add-route]\n\
WARNING: Line lacks whitespace around operator
#568 FILE: utilities/ovn-nbctl.c:501:
lb-add LB VIP[:PORT] IP[:PORT]... [PROTOCOL] [ADDRESS_FAMILY]\n\
WARNING: Line lacks whitespace around operator
#571 FILE: utilities/ovn-nbctl.c:504:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#575 FILE: utilities/ovn-nbctl.c:508:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#577 FILE: utilities/ovn-nbctl.c:510:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#580 FILE: utilities/ovn-nbctl.c:513:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#582 FILE: utilities/ovn-nbctl.c:515:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#593 FILE: utilities/ovn-nbctl.c:524:
dhcp-options-list lists the DHCP_Options rows\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#594 FILE: utilities/ovn-nbctl.c:525:
dhcp-options-set-options DHCP_OPTIONS_UUID KEY=VALUE [KEY=VALUE]...\n\
WARNING: Line lacks whitespace around operator
#597 FILE: utilities/ovn-nbctl.c:527:
dhcp-options-get-options DHCP_OPTIONS_UUID\n\
WARNING: Line is 80 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#608 FILE: utilities/ovn-nbctl.c:540:
set-ssl PRIV-KEY CERT CA-CERT [SSL-PROTOS [SSL-CIPHERS [SSL-CIPHERSUITES]]]\n\
WARNING: Line lacks whitespace around operator
#609 FILE: utilities/ovn-nbctl.c:541:
set the SSL/TLS configuration\n\
WARNING: Line lacks whitespace around operator
#616 FILE: utilities/ovn-nbctl.c:544:
pg-add PG [PORTS] create port group PG with optional PORTS\n\
WARNING: Line lacks whitespace around operator
#617 FILE: utilities/ovn-nbctl.c:545:
pg-set-ports PG PORTS set PORTS on port group PG\n\
WARNING: Line lacks whitespace around operator
#618 FILE: utilities/ovn-nbctl.c:546:
pg-del PG delete port group PG\n\
WARNING: Line lacks whitespace around operator
#619 FILE: utilities/ovn-nbctl.c:547:
pg-get-ports PG get PORTS on port group PG\n\
WARNING: Line lacks whitespace around operator
#625 FILE: utilities/ovn-nbctl.c:550:
ha-chassis-group-add GRP create an HA chassis group GRP\n\
WARNING: Line lacks whitespace around operator
#626 FILE: utilities/ovn-nbctl.c:551:
ha-chassis-group-del GRP delete the HA chassis group GRP\n\
WARNING: Line lacks whitespace around operator
#627 FILE: utilities/ovn-nbctl.c:552:
ha-chassis-group-list [GRP] print the supplied HA chassis group or all\n\
WARNING: Line lacks whitespace around operator
#633 FILE: utilities/ovn-nbctl.c:554:
ha-chassis-group-add-chassis GRP CHASSIS PRIORITY\n\
WARNING: Line lacks whitespace around operator
#635 FILE: utilities/ovn-nbctl.c:556:
ha-chassis-group-remove-chassis GRP CHASSIS\n\
WARNING: Line lacks whitespace around operator
#637 FILE: utilities/ovn-nbctl.c:558:
ha-chassis-group-set-chassis-prio GRP CHASSIS PRIORITY\n\
WARNING: Line lacks whitespace around operator
#662 FILE: utilities/ovn-nbctl.c:578:
[--may-exist]\n\
WARNING: Line lacks whitespace around operator
#666 FILE: utilities/ovn-nbctl.c:581:
[--if-exists]\n\
WARNING: Line lacks whitespace around operator
#671 FILE: utilities/ovn-nbctl.c:584:
static-mac-binding-list list all Static_MAC_Binding entries\n\
WARNING: Line lacks whitespace around operator
#675 FILE: utilities/ovn-nbctl.c:587:
lsp-hc-add PORT PROTOCOL SOURCE_IP [DST_PORT] ADDRESS\n\
WARNING: Line lacks whitespace around operator
#678 FILE: utilities/ovn-nbctl.c:589:
lsp-hc-del PORT [HC_UUID] delete health check monitoring for PORT\n\
Lines checked: 685, Warnings: 124, Errors: 0
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
