On Tue, Jul 11, 2017 at 08:15:00PM +0530, [email protected] wrote:
> From: Zongkai LI <[email protected]>
>
> This patch adds logical flows which sends IPv6 Router Advertisement
> packet in response to the IPv6 Router Solicitation request. It uses
> the actions "put_nd_ra_opts" to transform the RS packet to RA packet
> in the newly added ingress stage "lr_in_nd_ra_options" in router
> pipeline. If the action "put_nd_ra_opts" is successful, it sends the
> RA packet back to the originating port in the next ingress stage
> "lr_in_nd_ra_response".
>
> A new column "ipv6_ra_configs" is added in the Logical_Router_Port
> table, which the CMS is expected to configure IPv6 RA
> configurations - "address_mode" and "mtu" for adding these flows.
>
> Co-authored-by: Numan Siddique <[email protected]>
> Signed-off-by: Zongkai LI <[email protected]>
> Signed-off-by: Numan Siddique <[email protected]>
Thanks for working on this!
"checkpatch" reports:
WARNING: Line length is >79-characters long
#32 FILE: ovn/northd/ovn-northd.8.xml:1583:
Solicitation packet and applies the action
<code>put_nd_ra_opts</code>
WARNING: Line length is >79-characters long
#180 FILE: ovn/northd/ovn-northd.c:2640:
ovn_lflow_add(lflows, od, S_SWITCH_IN_PRE_ACL, 110, "(nd_rs ||
nd_ra)", "next;");
WARNING: Line length is >79-characters long
#182 FILE: ovn/northd/ovn-northd.c:2642:
ovn_lflow_add(lflows, od, S_SWITCH_OUT_PRE_ACL, 110, "(nd_rs ||
nd_ra)", "next;");
WARNING: Line length is >79-characters long
#356 FILE: ovn/ovn-nb.xml:1293:
<ref table="Logical_Router_Port"/> table's <ref
table="Logical_Router_Port"
WARNING: Line length is >79-characters long
#392 FILE: ovn/ovn-sb.xml:911:
<li><code>nd_rs</code> expands to <code>icmp6.type == 133
&& icmp6.code == 0 && ip.ttl == 255</code></li>
WARNING: Line length is >79-characters long
#393 FILE: ovn/ovn-sb.xml:912:
<li><code>nd_ra</code> expands to <code>icmp6.type == 134
&& icmp6.code == 0 && ip.ttl == 255</code></li>
Can you fix that up, rebase, and repost?
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
