On 5/6/26 5:07 PM, David Marchand wrote: > On Tue, 28 Apr 2026 at 17:20, Ilya Maximets <[email protected]> wrote: >> >> This functionality was deprecated in 3.7 due to lack of use, testing >> and maintenance. It's time to remove it. >> >> Signed-off-by: Ilya Maximets <[email protected]> > > [snip] >> - /* Check for a partial hardware offload match. */ >> - if (hwol_enabled) { >> - if (OVS_UNLIKELY(dp_netdev_hw_flow(pmd, packet, &f))) { > > This removes the last user of dp_netdev_hw_flow out of dpif-netdev.c. > Looking at git history, exporting this symbol was done for > implementing AVX512 dpif implem, so it makes more sent to me that we > unexport this symbol in this patch rather than in the next one. > >
[...] >> - >> - dp_netdev_batch_execute(pmd, &action_batch, rules[rule_pkt_idx], >> - bytes, tcp_flags); > > Similar to my previous comment, this hunk removes the last user of > dp_netdev_batch_execute. > It was added for AVX512 dpif implem, so I would drop it in this patch > rather than the next one. Good point. This is actually also the case for the last function in the dpif-netdev-private.h - dp_netdev_pmd_lookup_dpcls(). I'll just remove the entire header in this patch. It was created for the avx512 datapath implementation. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
