On 19 May 2026, at 17:08, Eelco Chaudron wrote:
> On 6 May 2026, at 11:05, Eli Britstein wrote:
>
>> DPDK auto-probes all PCI devices, including ones that can cause errors
>> in the log (virtio for example) and fail the test.
>>
>> The allow list from OVS_DPDK_VF_PCI_ADDRS introduced in [1] added the
>> PF's PCI address 6 times. Commit [2] doesn't have this environment
>> variable anymore.
>>
>> Instead of allowing the PF's address, allow only a dummy PCI address
>> as OVS works in hotplug method.
>>
>> [1]: 289e9f6baa7c ("tests: Add a simple DPDK rte_flow test framework.")
>> [2]: 9cabdd268c7e ("tests: Rework DPDK offload tests to use a simpler
>> interface argument.")
>>
>> Fixes: 9cabdd268c7e ("tests: Rework DPDK offload tests to use a simpler
>> interface argument.")
>> Signed-off-by: Eli Britstein <[email protected]>
>> ---
>
> This approach sounds good to me. One small comment below.
>
> //Eelco
>
>> tests/system-dpdk-offloads-macros.at | 15 +--------------
>> 1 file changed, 1 insertion(+), 14 deletions(-)
>>
>> diff --git a/tests/system-dpdk-offloads-macros.at
>> b/tests/system-dpdk-offloads-macros.at
>> index 194d8bca8..2a4591ced 100644
>> --- a/tests/system-dpdk-offloads-macros.at
>> +++ b/tests/system-dpdk-offloads-macros.at
>> @@ -73,20 +73,7 @@ m4_define([OVS_TRAFFIC_VSWITCHD_START],
>> dnl Userspace dpif may keep the kernel netdev until we remove it
>> explicitly.
>> AT_CHECK([ip link del ovs-netdev 2>/dev/null || true])
>> OVS_WAIT_WHILE([ip link show ovs-netdev])
>> - ALLOW_LIST=$(echo "$OVS_DPDK_VF_PCI_ADDRS" | awk '{
>> - for (i=1; i<=NF; i++) {
>> - split($i, parts, ",");
>> - addr = parts[1];
>> - if (addr != "" && !seen[addr]) {
>> - seen[addr] = 1;
>> - if (result == "")
>> - result = "--allow " addr;
>> - else
>> - result = result " --allow " addr;
>> - }
>> - }
>> - print result;
>> - }')
>> + ALLOW_LIST="--allow pci:0000:00:00.0"
>> OVS_DPDK_START([$ALLOW_LIST], [--disable-system],
>
> Now that the awk script is gone this is just a constant string.
> I would inline the value directly into OVS_DPDK_START() and drop
> the ALLOW_LIST variable entirely.
>
> OVS_DPDK_START([--allow pci:0000:00:00.0], [--disable-system],
> [-- set Open_vSwitch . other_config:hw-offload=true $3])
>
David just reminded me that his patch to disable probing went in last week, so
we can just remove this option.
>> [-- set Open_vSwitch . other_config:hw-offload=true $3])
>> dnl Add bridges, ports, etc.
>> --
>> 2.34.1
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
