Hello Ilya, On Tue, 19 May 2026 at 21:41, Ilya Maximets <[email protected]> wrote: > > On 5/19/26 4:09 PM, Eelco Chaudron wrote: > > > > > > On 19 May 2026, at 15:02, Ilya Maximets wrote: > > > >> On 5/18/26 4:00 PM, Eelco Chaudron wrote: > >>> > >>> > >>> On 6 May 2026, at 0:52, Ilya Maximets wrote: > >>> > >>>> Windows support was deprecated in 3.7, it's time to remove it. > >>>> > >>>> We already removed the installer and the datapath implementation. > >>>> Now removing all the code related to talking to the Windows datapath, > >>>> building on Windows, using MSVC as a compiler, and the final bits of > >>>> documentation related to Windows-specific behavior of certain features. > >>>> > >>>> It is possible to split this change into smaller parts, but it will > >>>> be a non-trivial amount of work to keep the patches in a working state > >>>> in the process. So, just removing everything at once. It would also > >>>> be easier to re-apply in case someone wants to resurrect this code or > >>>> maintain the Windows support in their own fork. > >>>> > >>>> A couple mentions of MSVC quirks are left in public headers as the > >>>> code is good enough and there is no real need to change the way it > >>>> is written at the moment. > >>>> > >>>> Signed-off-by: Ilya Maximets <[email protected]> > > [...] > > >> I suppose, reviewing the diff here is much easier than reviewing a v2. > >> I can fold the following changes into appropriate patches while applying > >> the set, if they look good to you: > > > > Thanks for the diff, this definitely made thinks a lot easier ;) > > > > With the diff applied, > > > > Acked-by: Eelco Chaudron <[email protected]> > > Thanks! > > I squashed the diff in, fixed the typo in commit message for patch 2, > rebased onto current main and applied the set. > > It's sad to see so much code gone, as a lot of work was put into it. > On the other hand, it's been in not so great shape for a while and has > fallen way behind modern MSVS and the Windows kernel. Now it's 10% > less code to worry about.
I had one comment on the SIGABRT hardcoded value which I find ugly. This could be reverted to previous code, iow: @@ -215,10 +215,9 @@ AT_CHECK([cd $longname && $PYTHON3 $abs_srcdir/test-unix-socket.py ../$longname/ AT_CLEANUP AT_SETUP([ovs_assert]) -# SIGABRT + 128 -exit_status=134 -AT_CHECK([ovstest test-util -voff -vfile:info '-vPATTERN:file:%c|%p|%m' --log-file assert], - [$exit_status], [], [stderr]) +AT_CHECK([ovstest test-util -voff -vfile:info '-vPATTERN:file:%c|%p|%m' --log-file assert || kill -l $?], + [0], [ABRT +], [stderr]) AT_CHECK([sed 's/\(opened log file\) .*/\1/ s/|[[^|]]*: /|/ And we could remove a wrapper around usleep in test-rculist.c. But otherwise the removal looks complete to me. Thanks. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
