This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. The commit introduced a problem that "File exists" will be reported when trying to open br0.
The operation that adds eth0 to br0 while moving IP address from eth0 to bridge internal interface br0 reproduces this issue. $ ip a del <ip> dev eth0; ip a add <ip> dev br0; ovs-vsctl add-port br0 eth0 $ ovs-dpctl show ... port 1: br0 (internal: open failed (File exists)) ... At this point restarting OVS will result in connection lost for the node. Reverting the change fixes the problem. Since adding physical interface to OVS bridge is quite normal operation, the problem is more severe than the original problem fixed by commit 67ac844, so revert this before a better fix is found for the original problem. Signed-off-by: Han Zhou <[email protected]> --- lib/netdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index 0d5fad5..e8843a8 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -416,8 +416,6 @@ netdev_open(const char *name, const char *type, struct netdev **netdevp) name, type); error = EAFNOSUPPORT; } - } else if (type && type[0] && strcmp(type, netdev->netdev_class->type)) { - error = EEXIST; } else { error = 0; } -- 2.1.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
