On Wed, Jun 3, 2026 at 7:02 PM Mark Michelson <[email protected]> wrote:
> Thanks Ales, > > Acked-by: Mark Michelson <[email protected]> > > On Wed, Jun 3, 2026 at 2:59 AM Ales Musil via dev > <[email protected]> wrote: > > > > The "ovn-nbctl show" command did not display the peer field > > of logical router ports, making it hard to see direct > > router-to-router connections configured via LRP.peer. > > > > Display the peer name for each logical router port that has > > one configured, improving debuggability of router peering > > topologies. > > > > Reported-at: https://redhat.atlassian.net/browse/FDP-3716 > > Assisted-by: Claude Opus 4.6, OpenCode > > Signed-off-by: Ales Musil <[email protected]> > > --- > > tests/ovn-nbctl.at | 4 ++++ > > utilities/ovn-nbctl.c | 5 +++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at > > index 890d24dbf..c27f58dff 100644 > > --- a/tests/ovn-nbctl.at > > +++ b/tests/ovn-nbctl.at > > @@ -1845,6 +1845,10 @@ AT_CHECK([ovn-nbctl lrp-list lr0 | uuidfilt], > [0], [dnl > > <1> (lrp1) > > ]) > > > > +AT_CHECK([ovn-nbctl show lr0 | grep 'peer:'], [0], [dnl > > + peer: lrp1-peer > > +]) > > + > > AT_CHECK([ovn-nbctl lrp-add lr0 lrp2 00:00:00:01:02:03]) > > AT_CHECK([ovn-nbctl lrp-list lr0 | uuidfilt], [0], [dnl > > <0> (lrp0) > > diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c > > index 0900254c4..2b70c9323 100644 > > --- a/utilities/ovn-nbctl.c > > +++ b/utilities/ovn-nbctl.c > > @@ -910,6 +910,10 @@ print_lr(const struct nbrec_logical_router *lr, > struct ds *s) > > ds_put_cstr(s, "]\n"); > > free(gcs); > > } > > + > > + if (lrp->peer) { > > + ds_put_format(s, " peer: %s\n", lrp->peer); > > + } > > } > > > > for (size_t i = 0; i < lr->n_nat; i++) { > > @@ -1022,6 +1026,7 @@ nbctl_pre_show(struct ctl_context *ctx) > > ovsdb_idl_add_column(ctx->idl, > &nbrec_logical_router_port_col_networks); > > ovsdb_idl_add_column(ctx->idl, > &nbrec_logical_router_port_col_options); > > ovsdb_idl_add_column(ctx->idl, > &nbrec_logical_router_port_col_gateway_chassis); > > + ovsdb_idl_add_column(ctx->idl, &nbrec_logical_router_port_col_peer); > > > > ovsdb_idl_add_column(ctx->idl, > &nbrec_gateway_chassis_col_chassis_name); > > > > -- > > 2.54.0 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > Thank you Mark, applied to main and backported down to 25.03 + 24.03. Regards, Ales _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
