Paolo Abeni <[email protected]> writes: > On 6/1/26 1:53 PM, Minxi Hou wrote: >> When ip-link output is unavailable, when the upcall daemon log has not >> been written yet, or when pahole does not know the OVS drop subsystem >> ID, the affected command substitutions silently produce empty strings. >> The caller then passes empty sha= or pid= arguments to ovs_add_flow, >> or matches against wrong drop reason codes, all without a diagnostic. >> >> Add [ -z ] guards immediately after each assignment. For test_arp_ping, >> also align the MAC extraction to use awk '/link\/ether/' as in >> test_pop_vlan. The drop_reason guard returns ksft_skip because an >> absent subsystem ID is an environment issue, not a test failure. >> >> Signed-off-by: Minxi Hou <[email protected]> > > IMHO this is net-next material. > > @Aaron, @Eelco, @Ilya: WDYT?
Agreed. > /P _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
