On 6/4/26 1:49 PM, Kevin Traynor wrote: > On 6/2/26 8:35 PM, Ilya Maximets wrote: >> The 'pmd-perf-show' command provides all the same information and more. >> It is also better visually structured and easier to read as a result. >> >> Let's remove the old 'pmd-stats-show' command, as there is no real need >> to have two commands reporting the same data. >> >> The only difference until now was that 'pmd-perf-show' didn't provide >> information for the "main" thread. This change makes it report the >> statistics for the aggregated "main" thread as well, omitting things >> related to CPU cycles, as we can't collect those for threads that are >> not pinned. For the same reason histograms are also always disabled. >> Omission is done by checking the total number of iterations to be zero. >> "main" thread doesn't start/end iterations. >> >> The actual unixctl command is preserved undocumented and serves as an >> alias for 'pmd-perf-show'. This should allow old scripts that are just >> capturing the output for humans (or LLMs?) to read to keep working. >> Note, however, that the exact output format for unixctl commands was >> never a guarantee, so scripts that attempt to parse the output may >> still break. >> >> Signed-off-by: Ilya Maximets <[email protected]> >> --- >> >> Version 2: >> * Rebased onto the current main. >> * Preserved iteration stats for PMD threads. [Kevin] >> * Fixed a typo. [Kevin] >> >> Documentation/intro/install/afxdp.rst | 2 +- >> Documentation/intro/install/dpdk.rst | 2 +- >> Documentation/topics/dpdk/bridge.rst | 4 +- >> Documentation/topics/dpdk/pmd.rst | 4 - >> NEWS | 4 + >> lib/dpif-netdev-perf.c | 41 +++-- >> lib/dpif-netdev-perf.h | 4 +- >> lib/dpif-netdev-unixctl.man | 59 ++++--- >> lib/dpif-netdev.c | 157 ++++-------------- >> tests/dpif-netdev.at | 20 +-- >> tests/pmd.at | 44 +++-- >> tests/system-dpdk-offloads.at | 8 +- >> .../plugins/system-logs/openvswitch.xml | 2 +- >> 13 files changed, 138 insertions(+), 213 deletions(-) > > LGTM, thanks. I tried it out and reporting as expected for no rx_packets > with/without iterations, main thread etc. > > Let's give it a day or two in case anyone else wants to review. > > Acked-by: Kevin Traynor <[email protected]> >
Thanks, Kevin and Eelco! Applied to main. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
