From: Dmitrii Shcherbakov <[email protected]>

Hi Aleksandra, thanks for the review!

> I don't think this part is needed. In the function above you already added an 
> early fallback
> to recompute when a distributed load balancer is present. It gets triggered 
> when we iterate
> over all new/affected datapaths in lb-data IP-node, so we'd only hit this 
> |if| for updating
> routers without distributed LBs, while the distributed LB itself is already 
> marked as affected.
> That case can be handled incrementally anyway.

Makes sense, reworked in v3-v4.

> We usually don't add chassis manually in tests, you can use the non-existent 
> chassis below.

ack, thanks for the tip.


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to