On 15 Jun 2026, at 14:27, Eli Britstein wrote:
> On 11/06/2026 15:18, Eelco Chaudron wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 18 May 2026, at 13:27, Eli Britstein wrote:
>>
>>> Introduce a new netdev type - "doca".
>>> The code is placed in new files.
>>> - ovs-doca: initialization of doca library and utility functions that
>>> are used currently by netdev-doca and also will be used for future
>>> hw-offload code.
>>> - netdev-doca: implementation of the new netdev.
>>>
>>> Supported ports are mlx5 ports in switch-dev mode only that with a NIC
>>> that supports hw-steering.
>>>
>>> The netdev has the concept of ESW manager. A representor port is
>>> functional only if its ESW manager is attached to OVS. In case it is
>>> not, the representor appears as functional in ovs-vsctl show, but it is
>>> not. Upon initializing of an ESW manager port, each representor is
>>> reconfigured to be functional, and upon destruction, they are first stopped.
>>>
>>> Steering infrastructure:
>>> - RX packets of all ports are steered to a common queue. This queue is
>>> polled using dpdk API and the packets are classified to a per-port
>>> memory structure.
>>> - TX packets are marked with the target port as metadata and sent to a
>>> common queue. The egress pipe matches on the metadata and forwards the
>>> packets accordingly.
>>>
>>> Signed-off-by: Eli Britstein <[email protected]>
>> Hi Eli,
>>
>> I guess we have some unresolved items from v3,
>> https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/,
>> which I guess should be addressed. I did not look at the full
>> details of our discussion, but I assume they will be fixed in v5.
>
> I revisited again the comments there. I saw there were some leftovers from
> things I handled (like consistent != DOCA_SUCCESS style for example) but not
> throughout all the code.
>
> I hope I didn't miss anything major.
I was referring to the comments that happened in the conversation after v4 was
sent out, so [#4](https://patchwork.ozlabs.org/comment/3693803/) and your reply
acknowledging you will fix them in v5,
[#5](https://patchwork.ozlabs.org/comment/3694460/)
>> Maybe you should just send out the v5 if you have it ready
>> addressing my comments, to quickly move forward when David's
>> comments come in. I guess his v4 comments will directly
>> apply to v5 as I skipped reviewing the DPDK part.
>
> I see David just sent some comments about the dpdk part, so I'll try to
> address them first before sending out v5.
>
> Do you want to point me to the specific unresolved items or we'll start a new
> session of comments when I send v5?
Let's focus on the v5, once it's out. So we are not looking at two revisions in
parallel.
//Eelco
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
