We could busy loop if SB DB is slow to commit in flight txn. Return
the txn check for put_MAC/ND/FDB.

Fixes: d133a36ebd4f ("pinctrl: Convert the put_ARP/ND/FDB actions to be 
lockless.")
Signed-off-by: Ales Musil <[email protected]>
---
 controller/pinctrl.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index 12eb5d65f..fce1c4be0 100644
--- a/controller/pinctrl.c
+++ b/controller/pinctrl.c
@@ -4731,8 +4731,10 @@ pinctrl_wait(struct ovsdb_idl_txn *ovnsb_idl_txn)
     wait_activated_ports();
     ovs_mutex_unlock(&pinctrl_mutex);
 
-    wait_put_mac_bindings();
-    wait_put_fdbs();
+    if (ovnsb_idl_txn) {
+        wait_put_mac_bindings();
+        wait_put_fdbs();
+    }
 }
 
 #define PINCTRL_CFG_INTERVAL 100
-- 
2.54.0

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to