The feature change check was missing a bunch of flags.
Add all of them so the I-P can properly propagate the change.

Fixes: 43f741c2f029 ("northd: Explicitly handle SNAT for ICMP need frag.")
Fixes: d9c97878eb23 ("actions: New action ct_commit_to_zone.")
Fixes: 71752140ec24 ("features: Add detection for sample with registers.")
Fixes: 8114a5c606eb ("northd, controller: Use ct_next to get the CT state for 
direct SNAT.")
Fixes: 0d3203cc4630 ("chassis: Check for ability to flush using CT label/mark.")
Fixes: a0870575c138 ("lib: northd: Add a new ct-state-save feature flag.")
Signed-off-by: Ales Musil <[email protected]>
---
 northd/en-global-config.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/northd/en-global-config.c b/northd/en-global-config.c
index d49ddb94a..afc559160 100644
--- a/northd/en-global-config.c
+++ b/northd/en-global-config.c
@@ -773,6 +773,30 @@ chassis_features_changed(const struct chassis_features 
*present,
         return true;
     }
 
+    if (present->ct_commit_nat_v2 != updated->ct_commit_nat_v2) {
+        return true;
+    }
+
+    if (present->ct_commit_to_zone != updated->ct_commit_to_zone) {
+        return true;
+    }
+
+    if (present->sample_with_reg != updated->sample_with_reg) {
+        return true;
+    }
+
+    if (present->ct_next_zone != updated->ct_next_zone) {
+        return true;
+    }
+
+    if (present->ct_label_flush != updated->ct_label_flush) {
+        return true;
+    }
+
+    if (present->ct_state_save != updated->ct_state_save) {
+        return true;
+    }
+
     return false;
 }
 
-- 
2.54.0

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to