On 24 Jun 2026, at 16:17, Mike Pattrick wrote:
> On Mon, Jun 22, 2026 at 10:57 AM Eelco Chaudron via dev < > [email protected]> wrote: > >> When dummy_allocate_flow_mark() fails and returns INVALID_FLOW_MARK, >> the code jumps to exit_unlock with off_flow still set to NULL. >> At exit_unlock, off_flow->stats is dereferenced if put->stats is >> non-NULL, causing a null pointer dereference. >> >> Fix by also checking that no error occurred before accessing >> off_flow->stats, since off_flow is guaranteed to be non-NULL >> on the success path. >> >> Fixes: e86d368c6e16 ("dummy-offload: Add simulated hardware offload.") >> Reported by Coverity: CID 561159. >> Signed-off-by: Eelco Chaudron <[email protected]> >> --- > > > Thanks for fixing this Eelco. > > Acked-by: Mike Pattrick <[email protected]> Thanks Mike for the review. Patch applied to main. //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
