On Fri, Jun 26, 2026 at 5:44 AM Dumitru Ceara <[email protected]> wrote:
>
> On 6/26/26 11:26 AM, Numan Siddique wrote:
> > On Wed, Jun 24, 2026, 8:27 a.m. Dumitru Ceara via dev <
> > [email protected]> wrote:
> >
> >> On 6/24/26 11:26 AM, Ales Musil wrote:
> >>> On Wed, Jun 24, 2026 at 9:49 AM Dumitru Ceara via dev <
> >>> [email protected]> wrote:
> >>>
> >>>> Those functions fully recompute the parsed routes (for static routes)
> >>>> and router policy collections.  Before doing that they clear the
> >>>> previous state.  So there's nothing left to be marked as stale, it's all
> >>>> gone before we add new routes.
> >>>>
> >>>> That allows us to remove the (broken) staleness checks that were causing
> >>>> long recompute times for routes and policies.
> >>>>
> >>>> A v1 of this series included only the routes fix:
> >>>>
> >>>>
> >> https://patchwork.ozlabs.org/project/ovn/patch/[email protected]/
> >>>>
> >>>> Changes in v2:
> >>>> - completely remove the staleness checks, they're useless
> >>>> - handle router policies recomputes too (as patch 2/2)
> >>>>
> >>>> Dumitru Ceara (2):
> >>>>   northd: Avoid useless iterations when recomputing routes.
> >>>>   northd: Avoid useless iterations when recomputing policies.
> >>>>
> >>>>  northd/northd.c | 35 -----------------------------------
> >>>>  northd/northd.h |  3 ---
> >>>>  2 files changed, 38 deletions(-)
> >>>>
> >>>> --
> >>>> 2.54.0
> >>>>
> >>>> _______________________________________________
> >>>> dev mailing list
> >>>> [email protected]
> >>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >>>>
> >>>>
> >>> The whole series looks good to me, thanks.
> >>>
> >>> Acked-by: Ales Musil <[email protected]>
> >>>
> >>
> >> Thanks, Ales, for the review!  Applied to main and 26.03.
> >>
> >
> > Hi Dumitru,
> >
>
> Hi Numan,
>
> > Thanks for fixing these.  Any objections if I backport to 25.09 ? The
> > patches apply cleanly and the ci passes -
> > https://github.com/numansiddique/ovn/tree/branch-25.09_route_policy_fixes
> >
> > In our deployments , en_route engine takes around 10 seconds to recompute
> > and these patches improve significantly.
> >
>
> Definitely no objections from my side.

Thanks.  Done.

Numan

>
> >
> > Thanks
> > Numan
> >
> >
>
> Regards,
> Dumitru
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to