On 6/22/26 3:41 PM, Timothy Redaelli wrote:
> ovs-test is barely used nowadays.  Standard tools like iperf are
> preferred for performance testing.  Remove the utility, its man
> page, and all build system and packaging references.
> 
> Suggested-by: Ilya Maximets <[email protected]>
> Signed-off-by: Timothy Redaelli <[email protected]>
> ---
>  Documentation/automake.mk             |   1 -
>  Documentation/conf.py                 |   2 -
>  Documentation/ref/index.rst           |   5 -
>  Documentation/ref/ovs-test.8.rst      | 163 --------------------------
>  Documentation/ref/ovs-vlan-test.8.rst |   9 +-
>  NEWS                                  |   2 +
>  debian/openvswitch-test.install       |   2 -
>  rhel/openvswitch-fedora.spec.in       |   2 -
>  rhel/openvswitch.spec.in              |   2 -
>  utilities/.gitignore                  |   2 -
>  utilities/automake.mk                 |   3 -
>  utilities/ovs-test.in                 | 141 ----------------------
>  12 files changed, 3 insertions(+), 331 deletions(-)
>  delete mode 100644 Documentation/ref/ovs-test.8.rst
>  delete mode 100644 utilities/ovs-test.in

[...]

> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> index 7d2b8394f..359a6dd29 100644
> --- a/rhel/openvswitch-fedora.spec.in
> +++ b/rhel/openvswitch-fedora.spec.in
> @@ -418,13 +418,11 @@ fi
>  %{python3_sitelib}/ovs
>  
>  %files test
> -%{_bindir}/ovs-test
>  %{_bindir}/ovs-vlan-test
>  %{_bindir}/ovs-pcap
>  %{_bindir}/ovs-tcpdump
>  %{_bindir}/ovs-tcpundump
>  %{_datadir}/openvswitch/scripts/usdt/*
> -%{_mandir}/man8/ovs-test.8*
>  %{_mandir}/man8/ovs-vlan-test.8*
>  %{_mandir}/man1/ovs-pcap.1*
>  %{_mandir}/man8/ovs-tcpdump.8*
> diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in
> index ac234bd21..f119b7ae4 100644
> --- a/rhel/openvswitch.spec.in
> +++ b/rhel/openvswitch.spec.in
> @@ -97,8 +97,6 @@ install -p -m 644 -D selinux/openvswitch-custom.pp \
>  rm \
>      $RPM_BUILD_ROOT/usr/bin/ovs-testcontroller \
>      $RPM_BUILD_ROOT/usr/share/man/man8/ovs-testcontroller.8 \

Should remove the line continuation here.  It would've broken the build
if the spec wasn't already broken.

> -    $RPM_BUILD_ROOT/usr/bin/ovs-test \
> -    $RPM_BUILD_ROOT/usr/share/man/man8/ovs-test.8
>  (cd "$RPM_BUILD_ROOT" && rm -rf usr/%{_lib}/*.la)
>  (cd "$RPM_BUILD_ROOT" && rm -rf usr/include)
>  
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to