Minor nit inline.
________________________________________ From: [email protected] <[email protected]> on behalf of Alin Serdean <[email protected]> Sent: Thursday, July 13, 2017 9:40 PM To: [email protected] Subject: [ovs-dev] [PATCH 34/40] datapath-windows: Vport check RtlStringCbLengthW return value The result of `RtlStringCbLengthW` is not currently checked and triggers a warning using the WDK 8.1 static analysis. This patch treats the result of `RtlStringCbLengthW`. Signed-off-by: Alin Gabriel Serdean <[email protected]> --- datapath-windows/ovsext/Vport.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index 075f419..071bc31 100644 --- a/datapath-windows/ovsext/Vport.c +++ b/datapath-windows/ovsext/Vport.c @@ -1144,8 +1144,13 @@ GetNICAlias(PNDIS_SWITCH_NIC_PARAMETERS nicParam, if (status == STATUS_SUCCESS) { RtlStringCbPrintfW(portFriendlyName->String, IF_MAX_STRING_SIZE, L"%s", interfaceName); - RtlStringCbLengthW(portFriendlyName->String, IF_MAX_STRING_SIZE, - &len); + status = RtlStringCbLengthW(portFriendlyName->String, + IF_MAX_STRING_SIZE, &len); + if (!NT_SUCCESS(status)) { + OVS_LOG_ERROR("Fail to get the length of the string," + "status: %x", status); >> s/Fail/Failed + return status; + } portFriendlyName->Length = (USHORT)len; } else { OVS_LOG_ERROR("Fail to convert interface LUID to alias, status: %x", -- 2.10.2.windows.1 _______________________________________________ Acked-by: Shashank Ram <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
