Am Fri, Jun 26, 2026 at 05:59:19PM -0400 schrieb Aaron Conole via dev:
> Felix Huettner via dev <[email protected]> writes:
>
> > Co-Authored-by: Florian Werner <[email protected]>
> > Signed-off-by: Florian Werner <[email protected]>
> > Co-Authored-by: Sebastian Riese <[email protected]>
> > Signed-off-by: Sebastian Riese <[email protected]>
> > Signed-off-by: Felix Huettner <[email protected]>
> > ---
> > lib/conntrack.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/lib/conntrack.c b/lib/conntrack.c
> > index fd1be21df..ffff4111f 100644
> > --- a/lib/conntrack.c
> > +++ b/lib/conntrack.c
> > @@ -54,6 +54,9 @@ COVERAGE_DEFINE(conntrack_l4csum_checked);
> > COVERAGE_DEFINE(conntrack_l4csum_err);
> > COVERAGE_DEFINE(conntrack_lookup_natted_miss);
> > COVERAGE_DEFINE(conntrack_zone_full);
> > +COVERAGE_DEFINE(conntrack_remove);
> > +COVERAGE_DEFINE(conntrack_insert);
> > +COVERAGE_DEFINE(conntrack_maybe_not_found);
> >
> > struct conn_lookup_ctx {
> > struct conn_key key;
> > @@ -590,6 +593,7 @@ conn_clean(struct conntrack *ct, struct conn *conn)
> > return;
> > }
> >
> > + COVERAGE_INC(conntrack_remove);
> > ovs_mutex_lock(&ct->ct_lock);
> > conn_clean__(ct, conn);
> > ovs_mutex_unlock(&ct->ct_lock);
> > @@ -1029,6 +1033,7 @@ conn_insert(struct conntrack *ct, struct dp_packet
> > *pkt,
> > enum ct_alg_ctl_type ct_alg_ctl, uint32_t tp_id)
> > OVS_REQUIRES(ct->ct_lock)
> > {
> > + COVERAGE_INC(conntrack_insert);
>
> I think this can follow the variable declarations block. Most of OVS
> follows this convention (the instances I found where COVERAGE_INC
> precedes variable blocks, there are function calls which produce side
> effects).
Thanks a lot,
will be addressed in the next version
Felix
>
> > struct conn *nc = NULL;
> >
> > int64_t czl_limit;
> > @@ -1158,6 +1163,7 @@ conn_maybe_not_found(struct conntrack *ct, struct
> > dp_packet *pkt,
> > const char *helper, const struct alg_exp_node
> > *alg_exp,
> > enum ct_alg_ctl_type ct_alg_ctl, uint32_t tp_id)
> > {
> > + COVERAGE_INC(conntrack_maybe_not_found);
>
> Same comment.
>
> > struct conn *nc = NULL;
> >
> > /* Note that we only insert a connection if commit=true. In this
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
