On 6/30/26 10:18 AM, Eelco Chaudron wrote:
>
>
> On 29 Jun 2026, at 18:30, Ilya Maximets wrote:
>
>> The expected length check is using the OVS_TUNNEL_ATTR_MAX, that
>> limits OVS_VPORT_ATTR_OPTIONS, as a limit for OVS_TUNNEL_KEY_ATTR_*
>> attributes. That means that the majority of the tunnel attributes
>> are not checked (OVS_TUNNEL_ATTR_MAX is 2, the values above that
>> are skipped). This is not a big deal, as we're parsing the values
>> that either we did generate ourselves, or the values that kernel
>> provided to us. So the values can't really be wrong, unless there
>> is a bug somewhere else in OVS or in the kernel. But we should
>> still check things properly.
>>
>> Use the correct OVS_TUNNEL_KEY_ATTR_MAX instead.
>>
>> Fixes: 6b8da9e92269 ("odp-util: Correctly generate wildcards when formating
>> nested attributes.")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> Thanks for fixing, Ilya. Change looks good to me.
>
> Acked-by: Eelco Chaudron <[email protected]>
>
Thanks, Aaron and Eelco! Applied and backported down to 3.3.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
