On 7/2/26 9:37 AM, Frode Nordahl wrote:
> On 7/2/26 01:14, Ilya Maximets wrote:
>> Debian's pybuild system fails to build our python package:
>>
>>    E: pybuild pybuild:147: cannot detect build system, please use
>>       --system option or set PYBUILD_SYSTEM env. variable
>>
>> It doesn't fall back to setuptools anymore by default and requires
>> an explicit build system definition or forced build system via
>> command line options or environment variables.
>>
>> We could work around that by setting PYBUILD_SYSTEM in the debian
>> rules, but the real fix is to provide a minimal pyproject.toml that
>> would point tools to the right build system.  It is a better
>> solution as it is not limited to pybuild, but will help any other
>> similar tools as well.
>>
>> Nothing except for the build system is specified in the added
>> pyproject.toml on purpose.  Our setup.py handles the C extension
>> building that is not really possible to do in a declarative way.
>> Moving metadata from setup.py into pyproject.toml would require
>> creating a custom build backend script that would handle extension
>> building, which doesn't make a lot of sense at this time.  And we
>> should not split metadata across multiple files.  So, everything
>> stays where it is for now.
>>
>> Reported-at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1126096
>> Signed-off-by: Ilya Maximets <[email protected]>
>> ---
> 
> Thanks for the patch, LGTM.
> 
> Acked-by: Frode Nordahl <[email protected]>
> 
> I raised an MR with Debian to make sure we stay in sync [0], I see there are 
> other
> updates to debian/ this cycle and we'll make sure to consider these when 
> updating
> the package to the next version.
> 
> 0: 
> https://salsa.debian.org/openstack-team/third-party/openvswitch/-/merge_requests/72
> 

Thanks, Frode!  Yes, we removed some stuff this cycle, so some files no
longer exist and some licenses no longer used in OVS.  And there are
some changes in systemd service management.

I applied this patch to main and branch-3.7, as I suppose we'll be seeing
more issues with various tools in the future if we don't have modern -ish
python packaging, and 3.7 is supposed to become an LTS.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to