On Fri, Jul 14, 2017 at 02:22:16PM -0700, Joe Stringer wrote: > On 14 July 2017 at 14:03, Ben Pfaff <[email protected]> wrote: > > On Fri, Jul 14, 2017 at 01:59:06PM -0700, Joe Stringer wrote: > >> The style guide states that lines should not end with '&&', '||' '&' > >> '|', '?', ':'. Check for this and report an error. > >> > >> Signed-off-by: Joe Stringer <[email protected]> > > > > Hmm, is that right? It's pretty explicit about ?:, but I don't know > > about the others. > > Ah, right you are. It's not explicit about the others. That said, > following the explicit description for ?: there's a few examples that > apply this style also to &&,||,&,|. I can respin this patch if you > think this is too strict.
I personally like to treat && || & | on a case-by-case basis. Sometimes stuff lines up nicer one way, sometimes the other. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
