On 15 Jul 2026, at 15:57, Aaron Conole wrote:
> Modern optimizing compilers will automatically choose to inline when
> it is appropriate for specific functions. In fact, 'inline' is
> usually considered harmful[0] except in specific situations (such
> as using them in header files to prevent linker errors when the
> One Definition Rule needs to be relaxed).
>
> Additionally, the coding style guidelines strongly recommend against
> using static inline in a C file, and we should strengthen that
> by also requiring such instances be decorated with ALWAYS_INLINE.
>
> Issue a warning instead of an error because the checkpatch parsing
> system doesn't support multi-line code blocks properly, so it's best
> to keep this a warning to call attention to the instance of
> ``static inline`` without explicitly calling it an error.
>
> Signed-off-by: Aaron Conole <[email protected]>
Thanks Aaron for following up with the v2, and for including the
documentation update. The changes look good to me!
Acked-by: Eelco Chaudron <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
