On 7/9/26 7:50 AM, Eli Britstein wrote: > > On 08/07/2026 16:23, Ilya Maximets wrote: >> External email: Use caution opening links or attachments >> >> >> On 6/24/26 2:16 PM, Eli Britstein wrote: >>> On 24/06/2026 15:11, Ilya Maximets wrote: >>>> External email: Use caution opening links or attachments >>>> >>>> >>>> On 6/22/26 8:28 AM, Eli Britstein wrote: >>>>> On 19/06/2026 23:02, Ilya Maximets wrote: >>>>>> External email: Use caution opening links or attachments >>>>>> >>>>>> >>>>>> On 6/10/26 3:24 PM, Eli Britstein via dev wrote: >>>>>>> A multi-line sed script in check_logs is echoed to stderr when >>>>>>> 'make check' runs with set -x, causing false failures in >>>>>>> OVS_VSWITCHD_STOP even when no WARN/ERR/EMER lines are present. >>>>>>> Use grep to select log levels and single-line sed -e filters instead. >>>>>> Hi, Eli. Thanks for the patch! Though I wonder why are you running >>>>>> tests under -x? Usually that means that the test is doing too much >>>>>> stuff in pure shell, which means it's not properly written in the first >>>>>> place. In this case, I'd suggest to fix the test instead, so the test >>>>>> log is actually sufficient to understand what is going on with it. >>>>>> >>>>>> That said, the current check_logs seems fine to me as is and it's. >>>>> I usually don't run with -x. I ran it for some debug and saw this >>>>> failure. The issue is not a specific test that is not written properly, >>>>> but any test would fail if run with -x. >>>> What I'm saying is that there should be no reason to run any test >>>> with -x. If you needed to run some test with -x while debugging, >>>> it means the test doesn't print enough information to the log and >>>> should be fixed. >>> I agree there should be no reason to run with -x. >>> >>> However, it is a valid/supported option. >>> >>> I would expect OK tests to pass even running with it, enough information >>> or not. >>> >>> Currently they don't and this commit fixes it. >>> >>> Alternatively, we can deprecate the support of it if we think it has no >>> value. >> I'm not sure I follow. Where is this documented as supported? How do >> you enable this option while running the tests? > > OVS uses autotest infrastructure for the testsuite. The flags are > documented here: > > https://buildsystem-manual.sourceforge.net/testsuite-Invocation.html > > To run a test for example: > > Without (pass): > > make check TESTSUITEFLAGS='1' > > With (fail): > > make check TESTSUITEFLAGS='1 -x'
This works fine on my system. I suppose there is some difference in the shell used. With bash, for example, it refuses to emit tracing command for the log checks: Not enabling shell tracing (command contains an embedded newline) And so it is not a problem. What kind of shell are you using? Note: the 'ofproto - flush flows, groups, and meters for controller change' test fails under -x regardless of the log checking with some cryptic errors. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
