---------- Forwarded message --------- From: Matteo Perin <[email protected]> Date: Thu, Jul 23, 2026 at 11:28 AM Subject: Re: [ovs-dev] [PATCH ovn v2] controller: Add routing-protocol-redirect veth peer discovery. To: Ales Musil <[email protected]>
Hi Ales, Thanks again for the review. On Thu, 23 Jul 2026 at 09:09, Ales Musil <[email protected]> wrote: > +# Set HAVE_ETHTOOL >> +find_command ethtool >> > > Do we actually need the ethtool userspace binary? > AFAIK ovs is using the ioctl so the check for Linux > should be enough as we don't use the ethtool directly > in the test. > Yes, you are entirely correct, we no longer need ethtool for the OVN tes. That it a carryover from the old test when the whole discovery was made at the OVN level, but that is no longer the case. You can safely remove both this guard and the conditional skip at the start of the test. Thank you for noticing and I apologize for not cleaning up the test setup properly when reimplementing it. Best Regards, Matteo Forwarding it to the ML too. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
