On Sat, Jul 15, 2017 at 11:23:04AM +0900, Takashi YAMAMOTO wrote:
> Hi,
>
> 2017/07/15 6:55 "Ben Pfaff" <[email protected]>:
>
> On Sat, Jul 15, 2017 at 02:39:44AM +0900, YAMAMOTO Takashi wrote:
> > SUS says:
> > When jobs reports the termination status of a job,
> > the shell removes its process ID from the list of those
> > "known in the current shell execution environment";
> >
> > With NetBSD /bin/sh, the list involves zombie processes and
> > ends up with "can not fork" during test runs.
>
> Can you squash the new patch into the existing one? And then we can
> apply it unconditionally? It isn't great to have conditional code here,
> especially since the testsuite is distributed.
>
>
> I thought the existing windows patch was conditional for some reasons. Do
> you remember the reason?
Thanks for reminding me of that.
It's because the patch only works with some Autoconf versions:
commit 83e09b5dfa35b95e9995713bdfcb9a27f9b4ed7f
Author: Gurucharan Shetty <[email protected]> Thu Apr 23 07:13:04 2015
Committer: Gurucharan Shetty <[email protected]> Thu Apr 23 10:49:13 2015
testsuite: Don't apply the testsuite.patch on non-Windows platforms.
On CentOS machines which use autoconf version 2.63, the patch
application would fail.
Reported-by: Ian Stokes <[email protected]>
Tested-by: Ian Stokes <[email protected]>
Signed-off-by: Gurucharan Shetty <[email protected]>
This is probably true of the new patch that you are providing, too.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev