None of the tests below actually do TSO as part of their checks.
Most of them were probably simple copy/pasting from actual TSO tests
before software fallback and tunnel full support.
Specifically for the ping vlan over vxlan test, looking at the commit
that left the restriction in place, the original issue was addressed with
commit 4ba65112dc09 ("netdev-linux: Do not offload IP checksum.").
Signed-off-by: David Marchand <[email protected]>
---
tests/system-common-macros.at | 8 --------
tests/system-offloads-traffic.at | 1 -
tests/system-traffic.at | 3 ---
3 files changed, 12 deletions(-)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 97b80405bf..409df83c6f 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
@@ -331,14 +331,6 @@ m4_define([OFPROTO_CLEAR_DURATION_IDLE], [[sed -e
's/duration=.*s,/duration=<cle
m4_define([OVS_CHECK_TC_QDISC],
[AT_SKIP_IF([test $HAVE_TC = no])])
-# OVS_CHECK_TUNNEL_TSO()
-#
-# Macro to be used in general tunneling tests that could be also
-# used by system-tso. In that case, tunneling is not supported and
-# the test should be skipped.
-m4_define([OVS_CHECK_TUNNEL_TSO],
- [m4_ifdef([CHECK_SYSTEM_TSO], [AT_SKIP_IF(:)])])
-
# OVS_CHECK_VXLAN()
#
# Do basic check for vxlan functionality, skip the test if it's not there.
diff --git a/tests/system-offloads-traffic.at b/tests/system-offloads-traffic.at
index a51bba5f9b..cfcc5bd6c3 100644
--- a/tests/system-offloads-traffic.at
+++ b/tests/system-offloads-traffic.at
@@ -838,7 +838,6 @@ OVS_TRAFFIC_VSWITCHD_STOP(["/could not open network device
ovs-p0/d
AT_CLEANUP
AT_SETUP([offloads - ping over vxlan tunnel with gbp - offloads enabled])
-OVS_CHECK_TUNNEL_TSO()
OVS_CHECK_VXLAN()
OVS_TRAFFIC_VSWITCHD_START([], [], [-- set Open_vSwitch .
other_config:hw-offload=true])
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 6550f90d99..ffb80d1e2f 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -448,7 +448,6 @@ OVS_TRAFFIC_VSWITCHD_STOP
AT_CLEANUP
AT_SETUP([datapath - ping vlan over vxlan tunnel])
-OVS_CHECK_TUNNEL_TSO()
OVS_CHECK_VXLAN()
OVS_TRAFFIC_VSWITCHD_START()
@@ -1188,7 +1187,6 @@ AT_CHECK([ovs-pcap p0.pcap | grep -Eq
"^[[[:xdigit:]]]{24}86dd60000000003a1140fc
AT_CLEANUP
AT_SETUP([datapath - bridging two geneve tunnels])
-OVS_CHECK_TUNNEL_TSO()
OVS_CHECK_GENEVE()
OVS_TRAFFIC_VSWITCHD_START()
@@ -1265,7 +1263,6 @@ OVS_TRAFFIC_VSWITCHD_STOP
AT_CLEANUP
AT_SETUP([datapath - bridging IPv4 and IPv6 flow based geneve tunnels])
-OVS_CHECK_TUNNEL_TSO()
OVS_CHECK_GENEVE()
OVS_TRAFFIC_VSWITCHD_START()
--
2.54.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
