On 28 Jul 2026, at 19:10, Eli Britstein wrote:
> On 28/07/2026 13:28, Eelco Chaudron wrote: >> External email: Use caution opening links or attachments >> >> >> On 26 Jul 2026, at 17:33, Eli Britstein wrote: >> >>> From: Gaetan Rivet <[email protected]> >>> >>> Add a reference-counted key-value map. >>> >>> Duplicates take a reference on the original entry within the map, >>> leaving it in place. To be able to execute an entry creation after >>> determining whether it is already present or not in the map, >>> store relevant initialization and de-initialization functions. >>> >>> Signed-off-by: Gaetan Rivet <[email protected]> >>> Co-authored-by: Eli Britstein <[email protected]> >>> Signed-off-by: Eli Britstein <[email protected]> >>> --- >> Thanks, Eli, for the v6. I will try to review as much as I >> can before I go on PTO. It is also pending another review >> from David. However, this patch looks good to me now! > > I found log_node is missing for unref. I'll add it in v7: > > diff --git a/lib/refmap.c b/lib/refmap.c > index 3c1918114..2f98405dd 100644 > --- a/lib/refmap.c > +++ b/lib/refmap.c > @@ -454,6 +454,8 @@ refmap_unref(struct refmap *rfm, void *value) > return false; > } > > + log_node(rfm, "unref", node); > + > if (ovs_refcount_unref_if_not_last(&node->refcount)) { > This addition looks like a good one! With this change, you can keep my ack. //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
