Agreed. v9 uses a single socat -u SCTP4-LISTEN:4443,fork STDOUT
for the whole test, so the flow rules are the only thing that changes between the three phases. Both respawn blocks go away. > BUT, as sashiko points out, we do this multiple times, and don't even > check whether the listen socket successfully comes up in the second / > third ones. The check is there -- each respawn is followed by ovs_wait sctp_eps_has server 4443 For reference, the sashiko run on v8 reports no open concerns; the listener restart and that wait both appear under dismissed concerns. What is fair to say is that the check is weaker than it looks. sctp_eps_has matches on the local port alone, so across a restart it can assert only that some listener holds 4443, not that it is the new one. With a single forking listener that question does not arise, which is a better reason to make the change than the line count. > Sashiko seems to imply that we could also do the wait-test with longer > timeout, in the case that we respawn the listener. Not needed either way. Two of those dismissed concerns are about the restart itself, so dropping it removes the code they were about rather than widening a window around it. > https://netdev-ctrl.bots.linux.dev/logs/build/1137903/14722442/check_selftest/ That failure is unrelated to the listener. The selftest config check strips underscores before comparing keys, so CONFIG_IP_SCTP has to sort before CONFIG_IPV6 even though a plain sort puts it after. Fixed in v9, and validate_config_format.py is clean on the new file. Thanks for the review. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
