On Fri, Aug 14, 2026 at 11:16 AM Dumitru Ceara <[email protected]> wrote:
> On 8/14/26 11:11 AM, Ales Musil wrote: > > On Fri, Aug 14, 2026 at 10:58 AM Dumitru Ceara <[email protected]> > wrote: > > > >> On 8/13/26 9:06 AM, Ales Musil wrote: > >>> The ARCH had a proper default in ci.sh which was passed along. That > >>> was fine for regular tests, however, upgrade tests are executing > >>> linux-build.sh without specifying the ARCH. Use proper default in > >>> linux-build.sh. > >>> > >>> Signed-off-by: Ales Musil <[email protected]> > >>> --- > >> > >> Hi Ales, > >> > > > > Hi Dumitru, > > > > > >> > >>> .ci/linux-build.sh | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > >>> index d9b49b7b6..b51f43cff 100755 > >>> --- a/.ci/linux-build.sh > >>> +++ b/.ci/linux-build.sh > >>> @@ -8,7 +8,7 @@ if [ "$NO_DEBUG" = "0" ]; then > >>> set -x > >>> fi > >>> > >>> -ARCH=${ARCH:-"x86_64"} > >>> +ARCH=${ARCH:-$(uname -m)} > >> > >> While this is fine, patch 2/4 just removes this whole line. > >> > >> I guess we could skip this patch completely or.. keep this one and skip > >> patch 3/4. > >> > >> Maybe the latter is better, what do you think? > >> > > > > It is confusing. This patch changes the default in linux-build.sh. > > I think it's mostly me being a bit blind. :) > > > 2/4 removes it from ci.sh. So we cannot skip 2/4. Also we need to > > pass it in 3/4 for the compilation unless we want to backport this one > > down to 24.03. > > > > I see now, yeah, it's unfortunate but it makes sense: > > Acked-by: Dumitru Ceara <[email protected]> > > Regards, > Dumitru > > > > >> > >>> USE_SPARSE=${USE_SPARSE:-"yes"} > >>> COMMON_CFLAGS="" > >>> OVN_CFLAGS="" > >> > >> Regards, > >> Dumitru > >> > >> > > Regards, > > Ales > > > > Thank you Dumitru, applied to main. Regards, Ales _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
