Regards _Sugesh
> -----Original Message----- > From: Joe Stringer [mailto:[email protected]] > Sent: Saturday, July 15, 2017 12:43 AM > To: Chandran, Sugesh <[email protected]> > Cc: ovs dev <[email protected]>; Andy Zhou <[email protected]>; Zoltán > Balogh <[email protected]> > Subject: Re: [PATCH v2 3/4] tunneling: Calculate and update packet l4_offset > in tunnel push. > > On 4 July 2017 at 02:46, Sugesh Chandran <[email protected]> > wrote: > > The following tunnel combine patch series avoids the packets > > recirculation after the tunnel push. So it is necessary to populate > > all relevant packet meta data fields for the following combined action-set. > > > > Consider a chained tunnel test case shown below, > > > > PKT-IN --> TUNNEL_PUSH --> MOD_PKT_HDR --> TUNNEL_POP > > > > In this eg: the last tunnel_pop operation uses the l4_offset in the > > packet to validate the packets. So it must be calculated and updated > > in the packet before executing the action. Since there is no > > recirculation now on, this calculation is doing as part of tunnel_push. > > > > Signed-off-by: Sugesh Chandran <[email protected]> > > Signed-off-by: Zoltán Balogh <[email protected]> > > Co-authored-by: Zoltán Balogh <[email protected]> > > --- > > Could this be done inside netdev_tnl_push_ip_header() instead, for a > generic one-liner that applies to all IP tunnels? [Sugesh] Yes, agree with you,. Will move it to push_ip_header() function in the next version. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
