On Fri, Sep 11, 2026 at 10:10 AM Dumitru Ceara <[email protected]> wrote:
> On 9/11/26 8:56 AM, Ales Musil via dev wrote:
> > The MAC binding probing mechanism is based on egress traffic
> > activity. However, we would send probes for entries that never
> > processed any egress traffic. Skip probes for those as it doesn't
> > make sense to probe inactive entries.
> >
> > Fixes: 1e4d4409f391 ("controller: Send ARP/ND for stale mac_bindings
> entries.")
> > Reported-at: https://redhat.atlassian.net/browse/FDP-4285
> > Signed-off-by: Ales Musil <[email protected]>
> > ---
>
> Hi Ales,
>
> > controller/mac-cache.c | 4 ++++
> > tests/ovn.at | 20 ++++++++++++++++++--
> > 2 files changed, 22 insertions(+), 2 deletions(-)
> >
> > diff --git a/controller/mac-cache.c b/controller/mac-cache.c
> > index 359d4c18f..814da223b 100644
> > --- a/controller/mac-cache.c
> > +++ b/controller/mac-cache.c
> > @@ -853,6 +853,10 @@ mac_binding_probe_stats_process_flow_stats(
> > struct vector *stats_vec,
> > struct ofputil_flow_stats *ofp_stats)
> > {
> > + if (!ofp_stats->packet_count) {
> > + return;
> > + }
> > +
> > struct mac_cache_stats stats = (struct mac_cache_stats) {
> > .idle_age_ms = ofp_stats->idle_age * 1000,
> > .data.mb = (struct mac_binding_data) {
> > diff --git a/tests/ovn.at b/tests/ovn.at
> > index c8a27fcf6..ef236d215 100644
> > --- a/tests/ovn.at
> > +++ b/tests/ovn.at
> > @@ -37354,11 +37354,12 @@ check ovn-nbctl
> \
> > -- lrp-add lr lr-ls1 00:00:00:00:10:00 192.168.10.1/24 \
> > -- lsp-add-router-port ls1 ls1-lr lr-ls1 \
> > -- lsp-add ls1 vif1 \
> > - -- lsp-set-addresses vif1 "00:00:00:00:10:10 192.168.10.10"
> > + -- lsp-set-addresses vif1 "unknown"
> >
> > check ovs-vsctl \
> > -- add-port br-int vif1 \
> > - -- set interface vif1 external-ids:iface-id=vif1
> > + -- set interface vif1 external-ids:iface-id=vif1 \
> > + options:tx_pcap=hv1/vif1-tx.pcap options:rxq_pcap=hv1/vif1-rx.pcap
> >
> > OVN_POPULATE_ARP
> > wait_for_ports_up
> > @@ -37391,6 +37392,10 @@ dnl After waiting until the age threshold the
> entry should be deleted
> > sleep 3
> > check_row_count mac_binding 0 ip="192.168.10.20"
> >
> > +dnl There shouldn't be any probe packet.
> > +check touch empty
>
> Nit: We do " > empty" or ": > empty" in quite a few other places where
> we want an empty file, I think I'd do that here too.
>
> With this small thing addressed:
>
> Acked-by: Dumitru Ceara <[email protected]>
>
> Regards,
> Dumitru
>
>
Thank you Dumitru and Jacob,
applied to main and backported down to 25.09 with that nit addressed.
Regards,
Ales
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
