On 22 Sep 2026, at 13:36, Kevin Traynor wrote:
> On 9/18/26 10:49, Eelco Chaudron wrote:
>> This patch adds support for offload providers to hook into PMD thread
>> lifecycle events, specifically thread initialization, reinitialization,
>> and termination. The new pmd_thread_lifecycle() callback in
>> dpif_offload_class allows a provider to maintain per-PMD-thread context
>> across reloads and to release resources when a thread exits.
>>
>> Signed-off-by: Eelco Chaudron <[email protected]>
>> ---
>> v2:
>> - Addressed Kevin's review comment.
>
> Hi Eelco. Thanks for reworking. checkpatch complains a little [0], but I'd
> rather have the descriptive commit title. One nit below. Otherwise LGTM.
>
> Acked-by: Kevin Traynor <[email protected]>
Thanks for the review Kevin! I'll wait for Gaetan to ack, and commit. The below
is a warning so we can ignore it. Will remove the dict change on commit if
there are no further comment.
//Eelco
>
> [0]
> WARNING: Comment with 'xxx' marker
> #190 FILE: lib/dpif-offload.c:1735:
> /* XXX: Would be nice if we have a numa specific xzalloc(). */
>
> WARNING: The subject, '<area>: <summary>', is over 70 characters, i.e., 75.
> Subject: [PATCH] dpif-offload: Add PMD thread lifecycle hook for offload
> providers.
> Lines checked: 327, Warnings: 2, Errors: 0
>
>
>> ---
>> lib/dpif-netdev.c | 23 ++++++++
>> lib/dpif-offload-dummy.c | 22 ++++++++
>> lib/dpif-offload-provider.h | 14 +++++
>> lib/dpif-offload.c | 103 ++++++++++++++++++++++++++++++++++
>> lib/dpif-offload.h | 8 +++
>> tests/pmd.at | 25 +++++++++
>> utilities/checkpatch_dict.txt | 3 +
>> 7 files changed, 198 insertions(+)
>>
>
> <snip>
>
>> diff --git a/utilities/checkpatch_dict.txt b/utilities/checkpatch_dict.txt
>> index cb25a86ea..acdaf2c74 100644
>> --- a/utilities/checkpatch_dict.txt
>> +++ b/utilities/checkpatch_dict.txt
>> @@ -35,6 +35,7 @@ cpu
>> cpus
>> cstime
>> csum
>> +ctx
>> cutime
>> cvlan
>> datapath
>> @@ -45,6 +46,7 @@ decap
>> decapsulation
>> defrag
>> defragment
>> +deinitialization
>
> ^^^ not needed anymore
>
>> deref
>> dereference
>> dest
>> @@ -233,6 +235,7 @@ rebased
>> recirc
>> recirculation
>> recirculations
>> +reinitialization
>> revalidate
>> revalidation
>> revalidator
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
