On Wed, 23 Sep 2026 12:42:59 -0400 Willem de Bruijn wrote: > Precomputing in the caller, as the current series does, is fine too, > if some caller-specific context is needed. > > I'm mostly concerned about duplicating logic and the number of > functions touched in this series. But skb_segment itself is too > complex already, so preferable to minimize complication there. > (The reuse of partial for this purpose is very neat.) > > If only validate_xmit_skb allows this, because all other segmentation > callers do want full segmentation (not checked, but I can believe > that), the current approach is fine. If we can clean up the repeated > tests and simplify the code in general.
OK, I will try to simplify the code and reduce the hot path cost in v3. By the way, changing the signature of __skb_gso_segment() brings three extra call site changes, and that is a trade-off. __skb_gso_segment() and skb_gso_segment() already exist, and adding another function like skb_gso_segment_max_segs() would make the call chain confusing. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
