Re: [ovs-dev] [RFC 09/11] netdev-dpdk: Move transmission code.

[Eelco Chaudron via dev]

On 29 Sep 2026, at 10:34, David Marchand wrote:

> Move all preparation, packet copy and dump and transmission code in the
> common file.
> One consequence is that all debug logs are now under netdev_dpdk_common
> vlog.

See some nits below...

//Eelco

> diff --git a/lib/netdev-dpdk-common.c b/lib/netdev-dpdk-common.c

[...]

> +#include "sset.h"
> +#include "unaligned.h"
> +#include "userspace-tso.h"

These two includes do not appear to be needed.  No
symbols from unaligned.h or userspace-tso.h are used
in netdev-dpdk-common.c.

> +#include "util.h"

[...]

> diff --git a/lib/netdev-dpdk-common.h b/lib/netdev-dpdk-common.h

[...]

> +void netdev_dpdk_mbuf_dump(const char *prefix, const char *message,
> +                           const struct rte_mbuf *mbuf);

Same comment as earlier about parameter names that
can be omitted from prototypes when the type already
makes the purpose clear.  Goes for all new prototypes.

[...]

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev