On 10/12/26 2:00 PM, Eelco Chaudron via dev wrote:
>>> static void
>>> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
>>> index ee6ac873d..207c61ad5 100644
>>> --- a/tests/ofproto-dpif.at
>>> +++ b/tests/ofproto-dpif.at
>>> @@ -8303,6 +8303,21 @@ AT_CHECK_UNQUOTED([ovs-appctl fdb/stats-show br0 |
>>> grep static], [0], [dnl
>>> Current static MAC entries in the table : 17
>>> ])
>>>
>>> +dnl Check JSON output.
>>> +AT_CHECK([ovs-appctl --format json --pretty fdb/stats-show br0], [0], [dnl
>>> +{
>>> + "br0": {
>>
>> If the bridge name is a required argument, why do we need to report it here?
>
> Ilya, your comments make sense, however on this one we should still
> report the bridge name. If in the future we report multiple entries,
> we do not have to change the format. Also, the non-JSON version
> shows the bridge name as well.
>
> This is consistent with existing commands like fdb/show, dpif/show,
> and dpif/offload/show, which all use entity names as top-level JSON
> keys.
OK. May be with mentioning this in the commit message then.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
