On 10/19/26 5:50 AM, Fei Wang via dev wrote:
> parse_odp_push_nsh_action() stops scanning at the closing ')' but does
> not consume it, so parse_odp_action__() has to add one to its return
> value.  Coverity flags this 'retval + 1' as a potential integer
> overflow.
> 
> Make parse_odp_push_nsh_action() consume the ')' itself, the same way
> parse_odp_psample_action() does, so that the caller can return its
> result directly.  This removes the addition in the caller and makes
> the two parsers consistent.
> 
> Found by Coverity (INTEGER_OVERFLOW, return_value_error).
> 
> Signed-off-by: Fei Wang <[email protected]>
> ---
Thanks, Fei!  Applied.  There is no real reason to backport this,
as the issue should not be actually triggerable in real world.
But I was backporting other fixes and took this along down to 3.7.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to