Hi Jacob Thanks for the patch.
One (very small) nit below (which maintainers usually squash, but I can't speak for them). Acked-by: Xavier Simonart <[email protected]> On Thu, Oct 29, 2026 at 3:38 PM Jacob Tanenbaum <[email protected]> wrote: > tcpdump treats UDP port 8472 as VXLAN traffic and attempts to print the > inner Ethernet frame when it sees 8472 as the source port number. > > When get_random_port_number() returns 8472 it causes the check > > AT_CHECK([grep -v "$global_svc_mon_mac > $lsp_mac" lsp_in.tcpdump], [1]) > > to fail because the tcpdump prints an extra line per packet with the > empty non existant inner Ethernet frame (it isn't really VXLAN traffic). > > change the invocation of tcpdump to include "-q" to disable payload > decoding for all protocols which since we are only looking at the MAC > addresses is fine. > nit: I do not think that -q disables all protocol decoding. So I would use something like: Change the invocation of tcpdump to include "-q" to suppress the udp sub-decoder. Since we are only looking at the MAC addresses (printed via "-e", which "-q" doesn't affect), this is fine. > > Signed-off-by: Jacob Tanenbaum <[email protected]> > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index 3cb4b858a..e9e6d1ebd 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -22353,8 +22353,8 @@ check ovn-nbctl --wait=hv sync > > dnl Check mac address of probe requests and replies, they should use the > dnl global svc_monitor_mac. > -NETNS_START_TCPDUMP([lsp], [-nne -i lsp -Q in 'udp port 42'], [lsp_in]) > -NETNS_START_TCPDUMP([lsp], [-nne -i lsp -Q out 'udp port 42 || icmp'], > [lsp_out]) > +NETNS_START_TCPDUMP([lsp], [-nneq -i lsp -Q in 'udp port 42'], [lsp_in]) > +NETNS_START_TCPDUMP([lsp], [-nneq -i lsp -Q out 'udp port 42 || icmp'], > [lsp_out]) > > dnl Start a backend server, the monitor should change status to "online". > NETNS_DAEMONIZE([lsp], [ncat -l -u 42], [nc.pid]) > -- > 2.56.0 > > Thanks Xavier _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
