On 10/29/26 1:54 PM, Eelco Chaudron wrote:
>
>
> On 21 Oct 2026, at 14:57, Ilya Maximets via dev wrote:
>
>> Tests are matching on words 'wrong' and 'bad' in tcpdump output to
>> capture reports about incorrect checksums. However, 'bad' is a valid
>> hex string and can occur as part of IPv6 flowlabel or some other parts
>> of the packet. Let's match on words instead of simply sub-strings.
>>
>> Example of the failed check from our CI:
>>
>> $ tcpdump -n -v "icmp6" -r p0.pcap 2>/dev/null | grep -E 'wrong|bad'
>> 11:37:41.485535 IP6 (flowlabel 0xbad6a, hlim 64,
>> next-header ICMPv6 (58), ... fc00::2 > fc00::1:[icmp6 sum ok] ICMP6
>>
>> Also, let's actually log the output so it's easier to understand what
>> happened from the log without the need to run tcpdump manually on the
>> captured pcap manually.
>>
>> Chances to hit this issue are quite low, but it happened more than
>> once at this point.
>>
>> Fixes: b020a416e24c ("System Tests: Enhance NAT tests.")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> Change looks good to me. Thanks for fixing Ilya.
>
> Acked-by: Eelco Chaudron <[email protected]>
Thanks! Applied and backported down to 3.3.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
