On 3 Nov 2026, at 13:01, David Marchand wrote:

> The mempool related code has no strong ties with the netdev_dpdk object.
> Move this code for reuse.
>
> Signed-off-by: David Marchand <[email protected]>

Thanks for fixing my earlier comments.  Found one additional
issue, see below.  The rest looks good to me.  With that
changed, add my Acked-by to the non-RFC version.

//Eelco

> ---
>  lib/netdev-dpdk-common.c | 438 +++++++++++++++++++++++++++++++++++
>  lib/netdev-dpdk-common.h |  53 +++++
>  lib/netdev-dpdk.c        | 488 +--------------------------------------
>  tests/system-dpdk.at     |   1 +
>  4 files changed, 504 insertions(+), 476 deletions(-)
>
> diff --git a/lib/netdev-dpdk-common.c b/lib/netdev-dpdk-common.c
> index ce510d7bc..66cf4de01 100644
> --- a/lib/netdev-dpdk-common.c
> +++ b/lib/netdev-dpdk-common.c
> @@ -16,13 +16,24 @@
>
>  #include <config.h>
>
> +#include <rte_malloc.h>
> +#include <rte_mbuf.h>
> +#include <rte_mempool.h>
> +
> +#include "dp-packet.h"
> +#include "hash.h"
>  #include "netdev-dpdk-common.h"
>
>  #include <rte_malloc.h>

Should this one be removed?

[...]
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to