On 11/10/26 5:26 PM, Rosemarie O'Riorden via dev wrote:
> On 11/10/26 7:54 AM, Dumitru Ceara wrote:
>> On 11/9/26 7:15 PM, Rosemarie O'Riorden wrote:
>>> Hi Sasha,
>>>
>>
>> Hi Sasha, Rosemarie,
>>
>>> Thanks for the new version! Sorry I didn't see this sooner, it would be
>>> great if you could CC reviewers (me & Dumitru in this case) so we don't
>>> miss it. Also no reason to include or CC the anthropic noreply email. I
>>> think Assisted-by will be deprecated soon anyways (I guess someone just
>>> needs to post a patch to do it lol), but until then you can leave out
>>
>> I heard some hallway discussions at ovscon'26 between people debating
>> this but I don't think any official decision has been made.  Personally
>> I'd prefer to keep Assisted-by but I'll accept whatever we decide as a
>> community.
> 
> Ah ok, I also like it tbh so I would support keeping it, but same,
> whatever consensus we come to is fine by me.

The current tag is not compliant with the current policy though.
'noreply' emails make no sense in tags.

> 
>>> that email.
>>>
>>> Acked-by: Rosemarie O'Riorden <[email protected]>
>>>
>>
>> This isn't a proper review on my side yet, but I did add this patch to
>> my list and will come back to it as soon as possible.
>>
>>> On 10/28/26 4:57 PM, Alexandra Rukomoinikova via dev wrote:
>>>> Mirroring of type "lport" was done after ingress port security and
>>>> before egress port security, so the mirror did not show the traffic
>>>> that was really present on the port.  For example, if a VM is
>>>> compromised and sends packets with a spoofed source MAC, port security
>>>> drops them and they never reach the mirror target, although this is
>>>> exactly the traffic one would want to see.  In the egress direction it
>>>> is the opposite: packets destined to a MAC address that is not allowed
>>>> on the port are dropped by egress port security and never delivered to
>>>> the VM, but they were still mirrored, so the mirror target saw traffic
>>>> that the port never received.
>>>>
>>>> Mirror the traffic as close to the interface as possible, so that the
>>>> mirror target sees what the port actually sends and receives.
>>>>
>>>> Fixes: 2a2fe266d09c ("northd: Added support for port mirroring in OVN 
>>>> overlay.")
>>>> Signed-off-by: Alexandra Rukomoinikova <[email protected]>
>>>> Assisted-by: Claude Opus 5.5 <[email protected]>
>>>> ---
>>
>> Regards,
>> Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to