The ovs specs describe get and new but not the set and del commands the kernel has registered since the families were added. This series adds them and names the attributes each handler reads. Nothing here changes how the kernel behaves.
v7: https://lore.kernel.org/netdev/[email protected]/ - The ufid docs said a value outside 1-16 octets is read as absent, and that a dump ignores the attribute. Only a value longer than 16 octets is read as absent. A zero length value fails the policy check before the command runs, and the request fails with -ERANGE; a dump accepts the attribute and does not read it. - The del and key docs said that a del with an out of range ufid flushes the data path. That only holds when the request carries no key, which the text now says. - The get reply list names the last-used time and the TCP flags, which ovs_flow_cmd_fill_stats() fills for get and for dump, and the docs of the stats, the used time and the TCP flags now say replies and notifications rather than notifications only. - The vport set doc says what the command does instead of explaining why two attributes are missing from the list, and says that the type only has to match. - The datapath new doc reads as a sentence again, the masks cache size records its upper bound of 4096, and the vport new request list gains the port number, which its handler reads. - Patch 2 says why ifindex is s32, which is to match the policy and nla_get_s32_default() in the request path, and that the generated reply struct follows with a __s32 field while the reply itself keeps putting the value as u32. v6: https://lore.kernel.org/netdev/[email protected]/ - A del flushes the data path when it carries no key and no valid ufid, not when it carries neither. The kernel reads a ufid outside 1-16 octets as absent, so such a request flushes as well. The ufid doc now says that, and that a new request with such a value indexes the flow by its key instead, and the attribute records the minimum length the policy enforces. The same sentences in include/uapi/linux/openvswitch.h follow. - ifindex is declared s32 with a minimum of 0, which is how both policies read it. No request used the attribute before this series, which is why the type went unnoticed. - The ops skip strict and dump validation in the kernel, so get, new, del and set say so in all three specs. - Rebased onto current net-next. v5: https://lore.kernel.org/netdev/[email protected]/ - ovs_flow dump gets a request list of its own with ufid-flags. It shared the get list, which offered a key and a ufid the kernel ignores on a dump. The reply is unchanged. - The key, actions and ufid docs no longer claim those attributes are always present, and say what the exceptions are: a ufid-identified flow sends no key or actions when the request asked for them to be left out, a dump leaves the actions out when they do not fit, and a dump ignores the ufid. The same sentences in include/uapi/linux/openvswitch.h are updated to match, since the spec text was copied from there. - The key doc now says a get and a set need a key or a ufid, that a new request needs a key, and that a del carrying neither flushes the data path. - The ovs_datapath new and set docs say per-cpu-pids takes effect only when the same request sets OVS_DP_F_DISPATCH_UPCALL_PER_CPU in user-features. - The ovs_vport set doc says the vport is picked by name or by port number, names the rejections in the order the kernel checks them, and says upcall-pid is the only attribute that changes state. - Rebased onto current net-next after the merge window. v4: https://lore.kernel.org/netdev/[email protected]/ - ovs_vport set lists port-no and ifindex. lookup_vport() finds a vport by name or by port number, and returns -EOPNOTSUPP as soon as it sees an ifindex, before the type or the options are looked at. - ovs_datapath new lists masks-cache-size, per-cpu-pids and ifindex. new calls ovs_dp_change(), which reads the first two, and reads ifindex itself. - ovs_flow get lists probe. ovs_flow_cmd_get() reads it to decide whether to log. - The key attribute doc now says a new request needs a key even when it finds an existing flow and replaces its actions, and that a dump reads neither the key nor the ufid. A del with neither flushes the data path, and the del operation doc says so too. v3: https://lore.kernel.org/netdev/[email protected]/ - no change since v2. v2: https://lore.kernel.org/netdev/[email protected]/ - ovs_flow new lists ufid-flags and probe, which ovs_flow_cmd_new() reads. - The commit message now says probe changes from binary to flag, and that new needs CAP_NET_ADMIN. - The key attribute doc no longer says a key is required for every request except a dump. get, set and del accept a ufid with no key, and only a new flow needs a key. A set that replaces the actions still needs a key. Signed-off-by: Minxi Hou <[email protected]> Minxi Hou (2): Minxi Hou (2): netlink: specs: add ovs_flow del and set operations netlink: specs: add ovs datapath and vport set operations Documentation/netlink/specs/ovs_datapath.yaml | 36 ++++++- Documentation/netlink/specs/ovs_flow.yaml | 102 ++++++++++++++---- Documentation/netlink/specs/ovs_vport.yaml | 29 ++++- include/uapi/linux/openvswitch.h | 35 +++--- 4 files changed, 167 insertions(+), 35 deletions(-) base-commit: fa5196392691051963726787944db872420dfa75 -- 2.56.0 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
