On 12 Nov 2026, at 0:54, Ilya Maximets via dev wrote:

> An mbox in many cases has the Subject line wrapped at 78 characters
> as suggested in RFC 5322.  That includes the 'Subject: ' text itself
> and the '[PATCH ... ]' tags.  So, it is likely that a relatively short
> commit subject line gets wrapped.  This increases the length by an
> extra line break.  And we're also not taking into account the tags
> themselves while checking the length, resulting in false positive
> warnings:
>
>  == Checking "patch.mbox" ==
>  WARNING: The subject, '<area>: <summary>', is over 70 characters, i.e., 73.
>  Subject: [PATCH] dpif-offload: Add support for offload provider specific
>   dp-hash.
>  Lines checked: 671, Warnings: 1, Errors: 0
>
> Fix that by re-joining the split subject and stripping out the tags,
> so the subject line length checks are accurate.  This doesn't affect
> checking the git commits with -N, since we're formatting the patch
> without tags in this case and with an explicit %s that doesn't wrap.
>
> There is one last issue with this: if the patch file is fed through
> stdin, then we're not parsing it as email and only the first line of
> the wrapped subject gets checked resulting in false positive 'dot'
> warnings and false negative length check results.  Should be fixed
> separately.
>
> Fixes: 1b8fa4a66aa4 ("checkpatch: Add checks for the subject line.")
> Signed-off-by: Ilya Maximets <[email protected]>

Change looks good to me, and thanks for fixing my previous code ;)

Acked-by: Eelco Chaudron <[email protected]>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to