On Fri, 13 Nov 2026 13:46:25 +0100
Eric Dumazet <[email protected]> wrote:
> skb->transport_header is a 16-bit offset from skb->head, and U16_MAX is
> reserved as the "not set" value. skb_set_transport_header() silently
> truncates an offset that does not fit.
>
> __udp6_lib_err_encap() stores @offset, computed by icmpv6_notify() from
> the extension headers of the packet embedded in an ICMPv6 error. Should
> the value be truncated, the tunnel encap_err_lookup() and err_handler()
> callbacks would read the UDP header at the wrong place.
>
> Since commit 3744b0964d52 ("ipv6: Implement limits on extension header
> parsing") a single chain is bounded to IP6_MAX_EXT_HDRS_CNT headers
> (24576 bytes), so this needs a large skb->data - skb->head on top of it,
> for instance after several nested decapsulations, each of them possibly
> pulling its own extension header chain, since @offset is relative to
> the IPv6 header embedded in the ICMPv6 error. No reproducer was written,
> this is hardening.
>
> Use skb_set_transport_header_careful() and return an error if the
> offset can not be stored, in which case udpv6_err() ignores the
> ICMPv6 error. Do this before changing the network header, so that
> nothing has to be restored on failure.
Right, we can't call __udp6_lib_err_encap_no_sk() anyway in that case.
> Fixes: a36e185e8c85 ("udp: Handle ICMP errors for tunnels with same
> destination port on both endpoints")
> Cc: [email protected]
> Signed-off-by: Eric Dumazet <[email protected]>
Thanks for fixing this.
Reviewed-by: Stefano Brivio <[email protected]>
--
Stefano
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev